From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 644B7C433E1 for ; Tue, 18 Aug 2020 02:56:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A2EC2054F for ; Tue, 18 Aug 2020 02:56:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NuoSqE61" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726367AbgHRC4D (ORCPT ); Mon, 17 Aug 2020 22:56:03 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:52958 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726365AbgHRC4D (ORCPT ); Mon, 17 Aug 2020 22:56:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597719360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tTS4kUxBIacME4nPsCb/ggAGvoDIx/15keGtZzANr+4=; b=NuoSqE61ZROqpcqSa2RRIOirhuBs+vxia88a+UznHdkEn4W0JUEoRgiDSM9cisrb7Rap4X BefGm1L9TWJPwe1wLty1MReZqgwL55C1rfhsxYzYkiF6U7fLnra74Epy+AQynm4erPY4tP D8ghe8k6FaEcTV8dYlv9oeaE2MyMmn4= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-371-jqnPfgeVOz-b3uOmuM5N7g-1; Mon, 17 Aug 2020 22:55:58 -0400 X-MC-Unique: jqnPfgeVOz-b3uOmuM5N7g-1 Received: by mail-pj1-f71.google.com with SMTP id a6so12018387pjd.1 for ; Mon, 17 Aug 2020 19:55:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tTS4kUxBIacME4nPsCb/ggAGvoDIx/15keGtZzANr+4=; b=U4diL0izqpIXE6MpCOmAEs3h0Ff1/yAasrCgoQPKMhikxVB6LQb2guzwH6Sw8apGaw toAeU+CkCgNRnd/cgeh7fezoAsC1vVpXDVISw3IDvQ3+yYEwKfQH2soDdec95CDUZfIh YA1NFkFzkNHboxHFUww0agVGftG7+yD4tx5yFPPUKcBBU/wo6tk91izm8qR8kS8lON/f 67gySpezzBloq/9p3IhUgxygeVZH3nUzU4UYKqxn/9Lzh1YvjzgOy85IyWJip2qMsOwR +PdS98kBgk+7hFnT9tbL8//yUA1neExDiDG6BZB+1/kj3Lpg5ziBHQZmtdg3bwlpSIul cSnQ== X-Gm-Message-State: AOAM532fMpztBDA56tFkH6ENdg929XU0gmpSVYoGMupM/dl6K7ozYaU1 46/0b1UGabmye/uNBy7RsSpUa9qGqbHab8mPOJJ5GmiJhSQDjbqVNA5bBRsDCRmIAXmtRh/TTkO BzI5hnd4injcbuENy X-Received: by 2002:a63:f44b:: with SMTP id p11mr7580099pgk.324.1597719357304; Mon, 17 Aug 2020 19:55:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqQMJfYvM9k9/9TjsuxkVZUCQwUTlIBrnW1m2TdXIbvhJfDLq7QTE/YpTBqRKEMRtZsNR8VA== X-Received: by 2002:a63:f44b:: with SMTP id p11mr7580086pgk.324.1597719357044; Mon, 17 Aug 2020 19:55:57 -0700 (PDT) Received: from xiangao.remote.csb ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id u5sm7555640pfm.149.2020.08.17.19.55.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 19:55:56 -0700 (PDT) Date: Tue, 18 Aug 2020 10:55:46 +0800 From: Gao Xiang To: gregkh@linuxfoundation.org Cc: stable@vger.kernel.org, yuchao0@huawei.com Subject: Re: FAILED: patch "[PATCH] erofs: fix extended inode could cross boundary" failed to apply to 4.19-stable tree Message-ID: <20200818025546.GA6339@xiangao.remote.csb> References: <159766792693116@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159766792693116@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Aug 17, 2020 at 02:38:46PM +0200, gregkh@linuxfoundation.org wrote: > > The patch below does not apply to the 4.19-stable tree. > If someone wants it applied there, or to any other stable or longterm > tree, then please email the backport, including the original git commit > id to . > > thanks, > > greg k-h > > ------------------ original commit in Linus's tree ------------------ > > From 0dcd3c94e02438f4a571690e26f4ee997524102a Mon Sep 17 00:00:00 2001 > From: Gao Xiang > Date: Thu, 30 Jul 2020 01:58:01 +0800 > Subject: [PATCH] erofs: fix extended inode could cross boundary > > Each ondisk inode should be aligned with inode slot boundary > (32-byte alignment) because of nid calculation formula, so all > compact inodes (32 byte) cannot across page boundary. However, > extended inode is now 64-byte form, which can across page boundary > in principle if the location is specified on purpose, although > it's hard to be generated by mkfs due to the allocation policy > and rarely used by Android use case now mainly for > 4GiB files. > > For now, only two fields `i_ctime_nsec` and `i_nlink' couldn't > be read from disk properly and cause out-of-bound memory read > with random value. > > Let's fix now. > > Fixes: 431339ba9042 ("staging: erofs: add inode operations") > Cc: # 4.19+ > Link: https://lore.kernel.org/r/20200729175801.GA23973@xiangao.remote.csb > Reviewed-by: Chao Yu > Signed-off-by: Gao Xiang Yeah, due to code difference, will manually backport this later... Thanks, Gao Xiang