From: Greg KH <greg@kroah.com>
To: Adam Ford <aford173@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
stable <stable@vger.kernel.org>,
Adam Ford-BE <aford@beaconembedded.com>
Subject: Re: [PATCH] omapfb: dss: Fix max fclk divider for omap36xx
Date: Mon, 24 Aug 2020 10:16:06 +0200 [thread overview]
Message-ID: <20200824081606.GA248691@kroah.com> (raw)
In-Reply-To: <CAHCN7x+Hhx=pNidpBpmsT2_J6Og4ioC9Dq_aYa7vy8j-D8-waw@mail.gmail.com>
On Thu, Aug 13, 2020 at 11:41:57AM -0500, Adam Ford wrote:
> On Thu, Aug 6, 2020 at 4:46 AM Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> >
> > Hi Greg,
> >
> > On 05/08/2020 17:33, Greg KH wrote:
> > > On Tue, Aug 04, 2020 at 04:19:54PM +0300, Tomi Valkeinen wrote:
> > >> On 04/08/2020 16:13, Adam Ford wrote:
> > >>>
> > >>>
> > >>> On Thu, Jul 9, 2020 at 7:12 AM Adam Ford <aford173@gmail.com <mailto:aford173@gmail.com>> wrote:
> > >>>
> > >>> There appears to be a timing issue where using a divider of 32 breaks
> > >>> the DSS for OMAP36xx despite the TRM stating 32 is a valid
> > >>> number. Through experimentation, it appears that 31 works.
> > >>>
> > >>> This same fix was issued for kernels 4.5+. However, between
> > >>> kernels 4.4 and 4.5, the directory structure was changed when the
> > >>> dss directory was moved inside the omapfb directory. That broke the
> > >>> patch on kernels older than 4.5, because it didn't permit the patch
> > >>> to apply cleanly for 4.4 and older.
> > >>>
> > >>> A similar patch was applied to the 3.16 kernel already, but not to 4.4.
> > >>> Commit 4b911101a5cd ("drm/omap: fix max fclk divider for omap36xx") is
> > >>> on the 3.16 stable branch with notes from Ben about the path change.
> > >>>
> > >>> Since this was applied for 3.16 already, this patch is for kernels
> > >>> 3.17 through 4.4 only.
> > >>>
> > >>> Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev")
> > >>>
> > >>> Cc: <stable@vger.kernel.org <mailto:stable@vger.kernel.org>> #3.17 - 4.4
> > >>> CC: <tomi.valkeinen@ti.com <mailto:tomi.valkeinen@ti.com>>
> > >>> Signed-off-by: Adam Ford <aford173@gmail.com <mailto:aford173@gmail.com>>
> > >>>
> > >>>
> > >>> Tomi,
> > >>>
> > >>> Can you comment on this? The 4.4 is still waiting for this fix. The other branches are fixed.
> > >>
> > >> Looks good to me.
> > >>
> > >> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > >
> > > I don't seem to have the original of this anymore, can someone please
> > > resend it?
> >
> > I have attached the original.
>
> Greg,
>
> Do you have what you need? I see all the other kernels have been had
> the corresponding patches pushed, but 4.4 needed something different
> due to some path / naming changes.
All good, now queued up, thanks!
greg k-h
next prev parent reply other threads:[~2020-08-24 8:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 12:12 [PATCH] omapfb: dss: Fix max fclk divider for omap36xx Adam Ford
[not found] ` <CAHCN7x+crwfE4pfufad_WEUhiJQXccSZHot+YNDZzZKvqhrmWA@mail.gmail.com>
2020-08-04 13:19 ` Tomi Valkeinen
2020-08-05 14:33 ` Greg KH
2020-08-06 9:46 ` Tomi Valkeinen
2020-08-13 16:41 ` Adam Ford
2020-08-24 8:16 ` Greg KH [this message]
[not found] <CGME20200630182652eucas1p1ce5e07b065127e32ab734f4447c2f735@eucas1p1.samsung.com>
2020-06-30 18:26 ` Adam Ford
2020-07-03 7:17 ` Tomi Valkeinen
2020-07-03 19:36 ` Sam Ravnborg
2020-07-06 6:02 ` Tomi Valkeinen
2020-07-06 11:18 ` Adam Ford
2020-07-08 23:37 ` Adam Ford
2020-07-09 6:10 ` Greg KH
2020-07-10 14:23 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824081606.GA248691@kroah.com \
--to=greg@kroah.com \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=stable@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).