stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matteo Croce <mcroce@linux.microsoft.com>
To: linux-kernel@vger.kernel.org
Cc: Guenter Roeck <linux@roeck-us.net>,
	Petr Mladek <pmladek@suse.com>, Arnd Bergmann <arnd@arndb.de>,
	Mike Rapoport <rppt@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Pavel Tatashin <pasha.tatashin@soleen.com>,
	Robin Holt <robinmholt@gmail.com>,
	Fabian Frederick <fabf@skynet.be>,
	stable@vger.kernel.org
Subject: [PATCH 0/2] fix parsing of reboot= cmdline
Date: Fri, 16 Oct 2020 20:09:05 +0200	[thread overview]
Message-ID: <20201016180907.171957-1-mcroce@linux.microsoft.com> (raw)

From: Matteo Croce <mcroce@microsoft.com>

The parsing of the reboot= cmdline has two major errors:
- a missing bound check can crash the system on reboot
- parsing of the cpu number only works if specified last

Fix both, along with a small code refactor.

Matteo Croce (2):
  reboot: fix overflow parsing reboot cpu number
  reboot: fix parsing of reboot cpu number

 kernel/reboot.c | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

-- 
2.26.2


             reply	other threads:[~2020-10-16 18:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 18:09 Matteo Croce [this message]
2020-10-16 18:09 ` [PATCH 1/2] reboot: fix overflow parsing reboot cpu number Matteo Croce
2020-10-16 19:25   ` Kees Cook
2020-10-16 19:45   ` Pavel Tatashin
2020-10-19 13:18   ` Petr Mladek
2020-10-16 18:09 ` [PATCH 2/2] reboot: fix parsing of " Matteo Croce
2020-10-16 19:26   ` Kees Cook
2020-10-16 21:34     ` Matteo Croce
2020-10-16 19:46   ` Pavel Tatashin
2020-10-19 13:49   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201016180907.171957-1-mcroce@linux.microsoft.com \
    --to=mcroce@linux.microsoft.com \
    --cc=arnd@arndb.de \
    --cc=fabf@skynet.be \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=pasha.tatashin@soleen.com \
    --cc=pmladek@suse.com \
    --cc=robinmholt@gmail.com \
    --cc=rppt@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).