From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D64C55178 for ; Tue, 27 Oct 2020 14:18:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37EDE207BB for ; Tue, 27 Oct 2020 14:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603808291; bh=gu14B/3XyOqUww19uJ6tUihj6C0vESM6NGFqZSz5VoI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Fu5awvVCMFbxu8Vd49J0A9FoaHgrTXL3ZHWXiQPpMhfDBljKqMU28skvUO6FLzSX9 TgqC/VNJ/EvHgTCaPUSTIjzcQFVK/yaxH2hAvdZW6o+OIvne03vVmq45+63DzQkzpR lSAZcDlC5ABmEuB1NtB61KHMEDAFASyHECl8D6bQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2901022AbgJ0OSH (ORCPT ); Tue, 27 Oct 2020 10:18:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:41396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2901017AbgJ0OSH (ORCPT ); Tue, 27 Oct 2020 10:18:07 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3EB6E206F7; Tue, 27 Oct 2020 14:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603808286; bh=gu14B/3XyOqUww19uJ6tUihj6C0vESM6NGFqZSz5VoI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ioWVMA4HzzyHX0GrvgdbEQaUT5sNeVFwmdGonar7bmAdJV6CS1bvkDZk3Il8dHTZF s0WGQLB+6CXjqHYB6cbbMY19Yk5UAT8yvQuSA5zG7X71N3tUsXeJ/9Nwd1qPyP3M7E 9Pn1juhVMjj/nQ7wkztsAPjFF/1L5Ksv+BUamtJk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Borislav Petkov , Tero Kristo , Sasha Levin Subject: [PATCH 4.19 034/264] EDAC/ti: Fix handling of platform_get_irq() error Date: Tue, 27 Oct 2020 14:51:32 +0100 Message-Id: <20201027135432.261879287@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135430.632029009@linuxfoundation.org> References: <20201027135430.632029009@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Krzysztof Kozlowski [ Upstream commit 66077adb70a2a9e92540155b2ace33ec98299c90 ] platform_get_irq() returns a negative error number on error. In such a case, comparison to 0 would pass the check therefore check the return value properly, whether it is negative. [ bp: Massage commit message. ] Fixes: 86a18ee21e5e ("EDAC, ti: Add support for TI keystone and DRA7xx EDAC") Signed-off-by: Krzysztof Kozlowski Signed-off-by: Borislav Petkov Reviewed-by: Tero Kristo Link: https://lkml.kernel.org/r/20200827070743.26628-2-krzk@kernel.org Signed-off-by: Sasha Levin --- drivers/edac/ti_edac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c index 6ac26d1b929f0..3247689467435 100644 --- a/drivers/edac/ti_edac.c +++ b/drivers/edac/ti_edac.c @@ -278,7 +278,8 @@ static int ti_edac_probe(struct platform_device *pdev) /* add EMIF ECC error handler */ error_irq = platform_get_irq(pdev, 0); - if (!error_irq) { + if (error_irq < 0) { + ret = error_irq; edac_printk(KERN_ERR, EDAC_MOD_NAME, "EMIF irq number not defined.\n"); goto err; -- 2.25.1