From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8303C4363A for ; Wed, 28 Oct 2020 22:44:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EEC62072C for ; Wed, 28 Oct 2020 22:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603925084; bh=u0zpqZBA75YhMTCDK2IhnqlGdtca2dn1nTVqZw7Ot14=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=PRGnXTMrp1qBi1SNhNX/jbT1nQM8IRICzKUI9kwGeKF8N0A2fso25sqfPaxA2YH/G 1xCVwcL8BPk+h+asvJ1H0gLSuxCBfiSBsbNh6Si8R0biVflbqirT6pMQ4kWg8k1oUn lQSvJUV8lUaqOcwIwUcSOSxUdQS3wln+4bfOhUBM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389166AbgJ1Wob (ORCPT ); Wed, 28 Oct 2020 18:44:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:53228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389160AbgJ1WmX (ORCPT ); Wed, 28 Oct 2020 18:42:23 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8332247F1; Wed, 28 Oct 2020 16:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603903599; bh=u0zpqZBA75YhMTCDK2IhnqlGdtca2dn1nTVqZw7Ot14=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=euGVA9HlpXasrUOFGBJJZvv8Qjo5PBwZ/iN2wWfDmBPwQ6UATCjlwTH7csCVMwGMV /jSQ3k0xZitMLNf3fOCxhoyEytkkP+jHkCs2uLEYErtl/Tzj74E7ZZwThmkFaxLkIZ Kh+SW3kfInPmqvdc4bxy8RhhdcMa00Q/lPcZE0N0= Date: Wed, 28 Oct 2020 09:46:38 -0700 From: Jakub Kicinski To: Pavel Machek Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Vinay Kumar Yadav Subject: Re: [PATCH 4.19 018/264] chelsio/chtls: correct function return and return type Message-ID: <20201028094638.3284bded@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201028065803.GA8084@amd> References: <20201027135430.632029009@linuxfoundation.org> <20201027135431.522408687@linuxfoundation.org> <20201028065803.GA8084@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, 28 Oct 2020 07:58:04 +0100 Pavel Machek wrote: > > From: Vinay Kumar Yadav > > > > [ Upstream commit 8580a61aede28d441e1c80588803411ee86aa299 ] > > > > csk_mem_free() should return true if send buffer is available, > > false otherwise. > > > Fixes: 3b8305f5c844 ("crypto: chtls - wait for memory sendmsg, sendpage") > > This does not fix anything. In fact, binary code should be exactly > equivalent. It does not need to be in 4.19-stable. Not sure why you think binary code will be equivalent. The condition changed from: cdev->max_host_sndbuf != sk->sk_wmem_queued to cdev->max_host_sndbuf > sk->sk_wmem_queued That said Chelsio would have to comment if it really fixes any real user-visible issue :) > > @@ -914,9 +914,9 @@ static int tls_header_read(struct tls_hd > > return (__force int)cpu_to_be16(thdr->length); > > } > > > > -static int csk_mem_free(struct chtls_dev *cdev, struct sock *sk) > > +static bool csk_mem_free(struct chtls_dev *cdev, struct sock *sk) > > { > > - return (cdev->max_host_sndbuf - sk->sk_wmem_queued); > > + return (cdev->max_host_sndbuf - sk->sk_wmem_queued > 0); > > } > > > > static int csk_wait_memory(struct chtls_dev *cdev,