From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB70C388F9 for ; Tue, 3 Nov 2020 21:16:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5868206B5 for ; Tue, 3 Nov 2020 21:16:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604438211; bh=xqehS+iZ2ASA0KobECvx6VyPlf9EWBv5f2elTHK3dGY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nPEwP8bQP0JAbFMqHXt87/r/OSCph8BV+hnmsOR2I0m6/sc9TTsgeCspNE89fBlLc aFtfkdYe/Etq6VLCOXvU1ainNqvJpIHGsRlqzJ4o3j7sOBVD6N+TSgPg83tINIrGkU UwyGLa6dUSIP7wdI97kXG7UknPucQk/Jv4EnSD0o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388823AbgKCVQn (ORCPT ); Tue, 3 Nov 2020 16:16:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:52228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388794AbgKCVK4 (ORCPT ); Tue, 3 Nov 2020 16:10:56 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 78FE0205ED; Tue, 3 Nov 2020 21:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437856; bh=xqehS+iZ2ASA0KobECvx6VyPlf9EWBv5f2elTHK3dGY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xm2PqqYOWX2LYi3GpcgnJTvWctrNqVi/Zhlr7KBQEJFrBFoM3utxn/z1KUXHV3Jkh 3dFPDnFiIL/yK72p0VgJcUxmnS2g7uu+0Nn5cB0J4L+VBSMO+Kbk/6qEH0IHBiafBW KTpS1fZMTggXrThNP6oybtAAvAOz47RuJzKTJw2k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bart Van Assche , Douglas Gilbert , Jens Axboe , Sasha Levin Subject: [PATCH 4.14 059/125] sgl_alloc_order: fix memory leak Date: Tue, 3 Nov 2020 21:37:16 +0100 Message-Id: <20201103203205.506388421@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203156.372184213@linuxfoundation.org> References: <20201103203156.372184213@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Douglas Gilbert [ Upstream commit b2a182a40278bc5849730e66bca01a762188ed86 ] sgl_alloc_order() can fail when 'length' is large on a memory constrained system. When order > 0 it will potentially be making several multi-page allocations with the later ones more likely to fail than the earlier one. So it is important that sgl_alloc_order() frees up any pages it has obtained before returning NULL. In the case when order > 0 it calls the wrong free page function and leaks. In testing the leak was sufficient to bring down my 8 GiB laptop with OOM. Reviewed-by: Bart Van Assche Signed-off-by: Douglas Gilbert Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- lib/scatterlist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/scatterlist.c b/lib/scatterlist.c index 834c846c5af84..2cf02a82d502b 100644 --- a/lib/scatterlist.c +++ b/lib/scatterlist.c @@ -477,7 +477,7 @@ struct scatterlist *sgl_alloc_order(unsigned long long length, elem_len = min_t(u64, length, PAGE_SIZE << order); page = alloc_pages(gfp, order); if (!page) { - sgl_free(sgl); + sgl_free_order(sgl, order); return NULL; } -- 2.27.0