From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C04BDC388F7 for ; Wed, 4 Nov 2020 09:10:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F71F2242B for ; Wed, 4 Nov 2020 09:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604481005; bh=UAwU3IdltPLolHLJKrgS3yX1pyFLwdjEdZQk5vEQmhI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Q2ZyLslWvsJER/+uyqtx3GZlevKCIij7ZsOCz6I44FcxC/lvaOIlUzHJQADWymvQG 8pxUpewke+6E5sHG/nhhiftbVz7xLgS8Rab7Eq7n4zvq+rHI28UgV+T2+HccKrdAT1 r/9tgTuhKVYdsxCwugUtEvgZA9k2mV0oqEkNAjXc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728763AbgKDJJ4 (ORCPT ); Wed, 4 Nov 2020 04:09:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:58952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729113AbgKDJJy (ORCPT ); Wed, 4 Nov 2020 04:09:54 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C4312242A; Wed, 4 Nov 2020 09:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604480993; bh=UAwU3IdltPLolHLJKrgS3yX1pyFLwdjEdZQk5vEQmhI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sW34e9QQs+F0CO3t64LAWJAKA8bayNBUtyIOnqqB2nWAeUbpLNUgFvW12cWQs9nMC nQ3eTnM2Rn6qOvh5MG9gXo60E/GDsiBppa3agul9E7L2qijDq0rVDtBIPd0mbL7bZc +K2e0Xc+FO4Q9/hQpkYVXm3mr3xhZY889Fgsx2Kc= Date: Wed, 4 Nov 2020 10:10:45 +0100 From: Greg Kroah-Hartman To: Damien Le Moal Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Kanchan Joshi , Jens Axboe Subject: Re: [PATCH 5.9 374/391] null_blk: synchronization fix for zoned device Message-ID: <20201104091045.GE1588160@kroah.com> References: <20201103203348.153465465@linuxfoundation.org> <20201103203412.385651316@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Nov 03, 2020 at 11:36:35PM +0000, Damien Le Moal wrote: > On 2020/11/04 5:52, Greg Kroah-Hartman wrote: > > From: Kanchan Joshi > > > > commit 35bc10b2eafbb701064b94f283b77c54d3304842 upstream. > > > > Parallel write,read,zone-mgmt operations accessing/altering zone state > > and write-pointer may get into race. Avoid the situation by using a new > > spinlock for zoned device. > > Concurrent zone-appends (on a zone) returning same write-pointer issue > > is also avoided using this lock. > > > > Cc: stable@vger.kernel.org > > Fixes: e0489ed5daeb ("null_blk: Support REQ_OP_ZONE_APPEND") > > Signed-off-by: Kanchan Joshi > > Reviewed-by: Damien Le Moal > > Signed-off-by: Jens Axboe > > Signed-off-by: Greg Kroah-Hartman > > Greg, > > I sent a followup patch fixing a bug introduced by this patch, but I forgot to > mark it for stable. The patch is > > commit aa1c09cb65e2 "null_blk: Fix locking in zoned mode" > > Could you pickup that one too please ? It doesn't apply cleanly at all, can you provide a backport? thanks, greg k-h