From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA0AC4741F for ; Wed, 4 Nov 2020 09:50:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E351E221F9 for ; Wed, 4 Nov 2020 09:50:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604483452; bh=yoJtdRxBLu5Gkd9biPLrT1mjV1owIOhFjYFgVjOmkq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=P/oacj2z9ffWq2Jyu8phbfcITOnZyTjOVgwpEJaamJ+/3FhWwQjzW/0TjreMQg4g2 rs4w7/FvQV69vMr8WOEgepLHnnbP+eUEb0XQfwiTTuzCYDLpNwJH+/02ZxQ/GcOsHo hpYm+9yt/6gps/0bVS463YEcnMRfyUWhQFHP3Rdk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729026AbgKDJuv (ORCPT ); Wed, 4 Nov 2020 04:50:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:45166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbgKDJuv (ORCPT ); Wed, 4 Nov 2020 04:50:51 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4685022206; Wed, 4 Nov 2020 09:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604483450; bh=yoJtdRxBLu5Gkd9biPLrT1mjV1owIOhFjYFgVjOmkq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ck5gq18jALbodFtVh/J0/Im3El0+kbdbZY1AlOl0+Z0AzCePK8GShHxA83vtu4wJg r5aYCKzcrf5MVSHJDMaIZZHCchAO6/Zkk8I9hFQv6w6QafFd223/kwCZ6oJdwfSHhB y27MbyUNaYdgNrfQW1lUdBZ8mqbJL1nqGytcCnpE= Date: Wed, 4 Nov 2020 10:51:41 +0100 From: Greg Kroah-Hartman To: Damien Le Moal Cc: "stable@vger.kernel.org" , Jens Axboe Subject: Re: [PATCH] null_blk: Fix zone reset all tracing Message-ID: <20201104095141.GA1673068@kroah.com> References: <16044134474538@kroah.com> <20201104052914.156163-1-damien.lemoal@wdc.com> <20201104091015.GD1588160@kroah.com> <20201104091502.GA1646828@kroah.com> <20201104092742.GA1669921@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Nov 04, 2020 at 09:31:40AM +0000, Damien Le Moal wrote: > On 2020/11/04 18:26, Greg Kroah-Hartman wrote: > > On Wed, Nov 04, 2020 at 09:21:27AM +0000, Damien Le Moal wrote: > >> On 2020/11/04 18:14, Greg Kroah-Hartman wrote: > >>> On Wed, Nov 04, 2020 at 10:10:15AM +0100, Greg Kroah-Hartman wrote: > >>>> On Wed, Nov 04, 2020 at 02:29:14PM +0900, Damien Le Moal wrote: > >>>>> commit f9c9104288da543cd64f186f9e2fba389f415630 upstream. > >>>>> > >>>>> In the cae of the REQ_OP_ZONE_RESET_ALL operation, the command sector is > >>>>> ignored and the operation is applied to all sequential zones. For these > >>>>> commands, tracing the effect of the command using the command sector to > >>>>> determine the target zone is thus incorrect. > >>>>> > >>>>> Fix null_zone_mgmt() zone condition tracing in the case of > >>>>> REQ_OP_ZONE_RESET_ALL to apply tracing to all sequential zones that are > >>>>> not already empty. > >>>>> > >>>>> Fixes: 766c3297d7e1 ("null_blk: add trace in null_blk_zoned.c") > >>>>> Signed-off-by: Damien Le Moal > >>>>> Cc: stable@vger.kernel.org > >>>>> Signed-off-by: Jens Axboe > >>>>> --- > >>>>> drivers/block/null_blk_zoned.c | 14 ++++++++------ > >>>>> 1 file changed, 8 insertions(+), 6 deletions(-) > >>>> > >>>> Now queued up, thanks. > >>> > >>> Wait, no, I'll delay this one until the next round as it's not fixing > >>> something introduced in this -rc series. > >> > >> Yes, that problem is older. > >> The lock fix I sent goes on top of this one though. I can send the backport for > >> the lock fix without this patch applied. Is that OK ? > > > > If the order of the patches is needed, then yes, I can take both, please > > submit them as a patch series so that I know this is needed. > > OK. Sending that. Note that I still do not see Kanchan patch applied in stable > 5.9.y branch, so I will do the backport assuming it is applied. Or I can send > all 3 patches as the series. Which do you prefer ? All 3 is great, to ensure I have them all as I don't know what you mean by "Kanchan patch". thanks, greg k-h