From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dongli Zhang <dongli.zhang@oracle.com>,
linux-mm@kvack.org, netdev@vger.kernel.org, willy@infradead.org,
aruna.ramakrishna@oracle.com, bert.barbe@oracle.com,
rama.nichanamatlu@oracle.com, venkat.x.venkatsubra@oracle.com,
manjunath.b.patil@oracle.com, joe.jin@oracle.com,
srinivas.eeda@oracle.com, stable@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, vbabka@suse.cz
Subject: Re: [PATCH v3 1/1] page_frag: Recover from memory pressure
Date: Wed, 18 Nov 2020 15:23:46 -0800 [thread overview]
Message-ID: <20201118152346.5a4fe12d@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20201118131335.738bdade4f3dfcee190ea8c1@linux-foundation.org>
On Wed, 18 Nov 2020 13:13:35 -0800 Andrew Morton wrote:
> On Wed, 18 Nov 2020 11:46:54 -0800 Jakub Kicinski <kuba@kernel.org> wrote:
>
> > > 1. The kernel is under memory pressure and allocation of
> > > PAGE_FRAG_CACHE_MAX_ORDER in __page_frag_cache_refill() will fail. Instead,
> > > the pfmemalloc page is allocated for page_frag_cache->va.
> > >
> > > 2: All skb->data from page_frag_cache->va (pfmemalloc) will have
> > > skb->pfmemalloc=true. The skb will always be dropped by sock without
> > > SOCK_MEMALLOC. This is an expected behaviour.
> > >
> > > 3. Suppose a large amount of pages are reclaimed and kernel is not under
> > > memory pressure any longer. We expect skb->pfmemalloc drop will not happen.
> > >
> > > 4. Unfortunately, page_frag_alloc() does not proactively re-allocate
> > > page_frag_alloc->va and will always re-use the prior pfmemalloc page. The
> > > skb->pfmemalloc is always true even kernel is not under memory pressure any
> > > longer.
> > >
> > > Fix this by freeing and re-allocating the page instead of recycling it.
> >
> > Andrew, are you taking this via -mm or should I put it in net?
> > I'm sending a PR to Linus tomorrow.
>
> Please go ahead - if/when it appears in mainline or linux-next, I'll
> drop the -mm copy.
Okay, applied, thank you!
prev parent reply other threads:[~2020-11-18 23:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 20:10 [PATCH v3 1/1] page_frag: Recover from memory pressure Dongli Zhang
2020-11-16 8:37 ` Eric Dumazet
2020-11-18 19:46 ` Jakub Kicinski
2020-11-18 21:13 ` Andrew Morton
2020-11-18 23:23 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118152346.5a4fe12d@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aruna.ramakrishna@oracle.com \
--cc=bert.barbe@oracle.com \
--cc=davem@davemloft.net \
--cc=dongli.zhang@oracle.com \
--cc=edumazet@google.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=manjunath.b.patil@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=rama.nichanamatlu@oracle.com \
--cc=srinivas.eeda@oracle.com \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
--cc=venkat.x.venkatsubra@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).