From: Hazem Mohamed Abuelfotoh <abuehaze@amazon.com>
To: <netdev@vger.kernel.org>
Cc: <stable@vger.kernel.org>, <edumazet@google.com>,
<ycheng@google.com>, <ncardwell@google.com>, <weiwan@google.com>,
<astroh@amazon.com>, <benh@amazon.com>,
Hazem Mohamed Abuelfotoh <abuehaze@amazon.com>
Subject: [PATCH net] tcp: fix receive buffer autotuning to trigger for any valid advertised MSS
Date: Mon, 7 Dec 2020 11:46:25 +0000 [thread overview]
Message-ID: <20201207114625.9079-1-abuehaze@amazon.com> (raw)
In-Reply-To: <CADVnQymC1fLFhb=0_rXNSp2NsNncMMRv77aY=5pYxgmicwowgA@mail.gmail.com>
Previously receiver buffer auto-tuning starts after receiving
one advertised window amount of data.After the initial
receiver buffer was raised by
commit a337531b942b ("tcp: up initial rmem to 128KB
and SYN rwin to around 64KB"),the receiver buffer may
take too long for TCP autotuning to start raising
the receiver buffer size.
commit 041a14d26715 ("tcp: start receiver buffer autotuning sooner")
tried to decrease the threshold at which TCP auto-tuning starts
but it's doesn't work well in some environments
where the receiver has large MTU (9001) especially with high RTT
connections as in these environments rcvq_space.space will be the same
as rcv_wnd so TCP autotuning will never start because
sender can't send more than rcv_wnd size in one round trip.
To address this issue this patch is decreasing the initial
rcvq_space.space so TCP autotuning kicks in whenever the sender is
able to send more than 5360 bytes in one round trip regardless the
receiver's configured MTU.
Fixes: a337531b942b ("tcp: up initial rmem to 128KB and SYN rwin to around 64KB")
Fixes: 041a14d26715 ("tcp: start receiver buffer autotuning sooner")
Signed-off-by: Hazem Mohamed Abuelfotoh <abuehaze@amazon.com>
---
net/ipv4/tcp_input.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 389d1b340248..f0ffac9e937b 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -504,13 +504,14 @@ static void tcp_grow_window(struct sock *sk, const struct sk_buff *skb)
static void tcp_init_buffer_space(struct sock *sk)
{
int tcp_app_win = sock_net(sk)->ipv4.sysctl_tcp_app_win;
+ struct inet_connection_sock *icsk = inet_csk(sk);
struct tcp_sock *tp = tcp_sk(sk);
int maxwin;
if (!(sk->sk_userlocks & SOCK_SNDBUF_LOCK))
tcp_sndbuf_expand(sk);
- tp->rcvq_space.space = min_t(u32, tp->rcv_wnd, TCP_INIT_CWND * tp->advmss);
+ tp->rcvq_space.space = min_t(u32, tp->rcv_wnd, TCP_INIT_CWND * icsk->icsk_ack.rcv_mss);
tcp_mstamp_refresh(tp);
tp->rcvq_space.time = tp->tcp_mstamp;
tp->rcvq_space.seq = tp->copied_seq;
--
2.16.6
Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284
Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705
next prev parent reply other threads:[~2020-12-07 11:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 18:06 [PATCH net-next] tcp: optimise receiver buffer autotuning initialisation for high latency connections Hazem Mohamed Abuelfotoh
2020-12-04 18:19 ` Mohamed Abuelfotoh, Hazem
2020-12-04 18:41 ` Eric Dumazet
[not found] ` <3F02FF08-EDA6-4DFD-8D93-479A5B05E25A@amazon.com>
2020-12-07 15:25 ` Eric Dumazet
2020-12-07 16:09 ` Mohamed Abuelfotoh, Hazem
2020-12-07 16:22 ` Eric Dumazet
2020-12-07 16:33 ` Neal Cardwell
2020-12-07 17:08 ` Eric Dumazet
2020-12-07 20:09 ` Mohamed Abuelfotoh, Hazem
2020-12-07 23:22 ` Eric Dumazet
2020-12-07 17:16 ` Mohamed Abuelfotoh, Hazem
2020-12-07 17:27 ` Eric Dumazet
2020-12-08 16:28 ` Mohamed Abuelfotoh, Hazem
2020-12-08 16:30 ` Mohamed Abuelfotoh, Hazem
2020-12-08 16:46 ` Eric Dumazet
2020-12-07 16:34 ` Mohamed Abuelfotoh, Hazem
2020-12-07 17:46 ` Greg KH
2020-12-07 17:54 ` Mohamed Abuelfotoh, Hazem
2020-12-04 19:10 ` Eric Dumazet
2020-12-04 21:28 ` Neal Cardwell
2020-12-07 11:46 ` Hazem Mohamed Abuelfotoh [this message]
2020-12-07 18:53 ` [PATCH net] tcp: fix receive buffer autotuning to trigger for any valid advertised MSS Jakub Kicinski
[not found] <4ABEB85B-262F-4657-BB69-4F37ABC0AE3D@amazon.com>
2020-12-07 11:40 ` Hazem Mohamed Abuelfotoh
2020-12-07 15:37 ` Eric Dumazet
2020-12-07 16:08 ` Eric Dumazet
2020-12-07 17:49 ` Mohamed Abuelfotoh, Hazem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207114625.9079-1-abuehaze@amazon.com \
--to=abuehaze@amazon.com \
--cc=astroh@amazon.com \
--cc=benh@amazon.com \
--cc=edumazet@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=weiwan@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).