From: Miroslav Lichvar <mlichvar@redhat.com>
To: Joerg Vehlow <lkml@jv-coder.de>
Cc: Greg KH <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
John Stultz <john.stultz@linaro.org>
Subject: Re: [4.14] Failing selftest timer/adjtick
Date: Wed, 10 Feb 2021 14:19:16 +0100 [thread overview]
Message-ID: <20210210131916.GC1903164@localhost> (raw)
In-Reply-To: <239b8a9a-d550-11e3-4650-39ad5bd85013@jv-coder.de>
On Wed, Feb 10, 2021 at 02:07:21PM +0100, Joerg Vehlow wrote:
> On 2/10/2021 2:00 PM, Greg KH wrote:
> > Have you tried applying it to that tree to see if it solves your problem
> > and works properly? If so, please feel free to provide a working
> > backported copy, with your signed-off-by and we can consider it.
> It can be applied without any changes and fixes the problem, but since I
> have not a lot of knowledge about this subsystem, I don't know if this
> breaks anything or if it requires other patches to be applied first, to not
> break anything..
> Maybe the authors of the patch can check this easily or maybe know it.
> That's why I added them to the initial mail.
That patch cannot be applied alone. It would break the timekeeping in
not so obvious ways as there will be unexpected sources of the NTP
tracking error. IIRC, at least the following changes would need to be
included with it. There may be others.
c2cda2a5bda9 ("timekeeping/ntp: Don't align NTP frequency adjustments to ticks")
aea3706cfc4d ("timekeeping: Remove CONFIG_GENERIC_TIME_VSYSCALL_OLD")
d4d1fc61eb38 ("ia64: Update fsyscall gettime to use modern vsyscall_update")
My suggestion for a fix would be to increase the limit in the failing
test.
--
Miroslav Lichvar
next prev parent reply other threads:[~2021-02-10 13:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 12:43 [4.14] Failing selftest timer/adjtick Joerg Vehlow
2021-02-10 13:00 ` Greg KH
2021-02-10 13:07 ` Joerg Vehlow
2021-02-10 13:19 ` Miroslav Lichvar [this message]
2021-02-10 18:59 ` Naresh Kamboju
2021-02-11 10:34 ` Joerg Vehlow
2021-02-11 10:33 ` Joerg Vehlow
2021-02-11 10:45 ` Greg KH
2021-02-11 10:59 ` Miroslav Lichvar
2021-02-18 7:05 ` Joerg Vehlow
2021-03-01 7:04 ` Joerg Vehlow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210131916.GC1903164@localhost \
--to=mlichvar@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=lkml@jv-coder.de \
--cc=mingo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).