From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 509BFC433B4 for ; Mon, 19 Apr 2021 12:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31EE161057 for ; Mon, 19 Apr 2021 12:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbhDSMJx (ORCPT ); Mon, 19 Apr 2021 08:09:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:55376 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239042AbhDSMJw (ORCPT ); Mon, 19 Apr 2021 08:09:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 713AE60FE8; Mon, 19 Apr 2021 12:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618834162; bh=ZaI9NHDEa6fsjGMbFCAqAOcjQzb9w0Hpc1LWlMUbVfc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PlAaKiTLf3xpk7Dkb8M4VZAh627a/R091n2kFvS9uiNVAyjr86Q9vt3x6BZ+JMXS/ DijYkNEzFlWE+IEE366mUuLmul44IRLoIIuO6tDArcqQnPSrVQViM0SsPulcoDMEVX 5WJUXCSDfLIGYjEzsqBVxq5yO6Sp0vGC8QqTZqBm7Aoo6KfezDFJ9kEBOYZJTDzuj+ OxSZTENgRBwDoSjwXADkZxU7szmW6RBmldbBRA7JalEdN7k/vFDAMWRMY05chArcLo 9eGbx7dJI+NMSRkNi2033TUmfeh/oQ5wtjo4OrASu5ecs86D4WnkaPlY/XjiV3gI63 k7kFu47xYKxfg== Received: by pali.im (Postfix) id 7B53A76B; Mon, 19 Apr 2021 14:08:56 +0200 (CEST) Date: Mon, 19 Apr 2021 14:08:56 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Greg KH Cc: stable@vger.kernel.org, andrew@lunn.ch, davem@davemloft.net, kabel@kernel.org Subject: Re: [PATCH] net: phy: marvell: fix detection of PHY on Topaz switches Message-ID: <20210419120856.xtym4nhplgwrtoot@pali> References: <16187482432842@kroah.com> <161874858144103@kroah.com> <20210418131344.21024-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Monday 19 April 2021 14:05:18 Greg KH wrote: > On Sun, Apr 18, 2021 at 03:13:44PM +0200, Pali Rohár wrote: > > commit 1fe976d308acb6374c899a4ee8025a0a016e453e upstream. > > > > Since commit fee2d546414d ("net: phy: marvell: mv88e6390 temperature > > sensor reading"), Linux reports the temperature of Topaz hwmon as > > constant -75°C. > > > > This is because switches from the Topaz family (88E6141 / 88E6341) have > > the address of the temperature sensor register different from Peridot. > > > > This address is instead compatible with 88E1510 PHYs, as was used for > > Topaz before the above mentioned commit. > > > > Create a new mapping table between switch family and PHY ID for families > > which don't have a model number. And define PHY IDs for Topaz and Peridot > > families. > > > > Create a new PHY ID and a new PHY driver for Topaz's internal PHY. > > The only difference from Peridot's PHY driver is the HWMON probing > > method. > > > > Prior this change Topaz's internal PHY is detected by kernel as: > > > > PHY [...] driver [Marvell 88E6390] (irq=63) > > > > And afterwards as: > > > > PHY [...] driver [Marvell 88E6341 Family] (irq=63) > > > > Signed-off-by: Pali Rohár > > BugLink: https://github.com/globalscaletechnologies/linux/issues/1 > > Fixes: fee2d546414d ("net: phy: marvell: mv88e6390 temperature sensor reading") > > Reviewed-by: Marek Behún > > Reviewed-by: Andrew Lunn > > Signed-off-by: David S. Miller > > [pali: Backported to 5.4 version] > > --- > > This patch is backported to 5.4 version. Tested on Turris Mox with Topaz switch. > > What about a 5.10 version? Is manual backport required also for 5.10? I got email that automatic backporting failed only for 4.19 and 5.4 versions. > thanks, > > greg k-h