From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Vinod Koul <vkoul@kernel.org>, Sasha Levin <sashal@kernel.org>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH AUTOSEL 5.10 07/21] dmaengine: xilinx: dpdma: Fix race condition in done IRQ
Date: Mon, 19 Apr 2021 16:44:05 -0400 [thread overview]
Message-ID: <20210419204420.6375-7-sashal@kernel.org> (raw)
In-Reply-To: <20210419204420.6375-1-sashal@kernel.org>
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
[ Upstream commit 868833fbffbe51c487df4f95d4de9194264a4b30 ]
The active descriptor pointer is accessed from different contexts,
including different interrupt handlers, and its access must be protected
by the channel's lock. This wasn't done in the done IRQ handler. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/20210307040629.29308-3-laurent.pinchart@ideasonboard.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/dma/xilinx/xilinx_dpdma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
index d504112c609e..70b29bd079c9 100644
--- a/drivers/dma/xilinx/xilinx_dpdma.c
+++ b/drivers/dma/xilinx/xilinx_dpdma.c
@@ -1048,13 +1048,14 @@ static int xilinx_dpdma_chan_stop(struct xilinx_dpdma_chan *chan)
*/
static void xilinx_dpdma_chan_done_irq(struct xilinx_dpdma_chan *chan)
{
- struct xilinx_dpdma_tx_desc *active = chan->desc.active;
+ struct xilinx_dpdma_tx_desc *active;
unsigned long flags;
spin_lock_irqsave(&chan->lock, flags);
xilinx_dpdma_debugfs_desc_done_irq(chan);
+ active = chan->desc.active;
if (active)
vchan_cyclic_callback(&active->vdesc);
else
--
2.30.2
next prev parent reply other threads:[~2021-04-19 20:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 20:43 [PATCH AUTOSEL 5.10 01/21] HID: google: add don USB id Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 02/21] HID: alps: fix error return code in alps_input_configured() Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 03/21] HID cp2112: fix support for multiple gpiochips Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 04/21] HID: wacom: Assign boolean values to a bool variable Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 05/21] soc: qcom: geni: shield geni_icc_get() for ACPI boot Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 06/21] dmaengine: xilinx: dpdma: Fix descriptor issuing on video group Sasha Levin
2021-04-19 20:44 ` Sasha Levin [this message]
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 08/21] ARM: dts: Fix swapped mmc order for omap3 Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 09/21] net: geneve: check skb is large enough for IPv4/IPv6 header Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 10/21] dmaengine: tegra20: Fix runtime PM imbalance on error Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 11/21] s390/entry: save the caller of psw_idle Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 12/21] arm64: kprobes: Restore local irqflag if kprobes is cancelled Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 13/21] xen-netback: Check for hotplug-status existence before watching Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 14/21] cavium/liquidio: Fix duplicate argument Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 15/21] i2c: mv64xxx: Fix random system lock caused by runtime PM Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 16/21] kasan: fix hwasan build for gcc Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 17/21] csky: change a Kconfig symbol name to fix e1000 build error Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 18/21] ia64: fix discontig.c section mismatches Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 19/21] ia64: tools: remove duplicate definition of ia64_mf() on ia64 Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 20/21] gcov: clang: fix clang-11+ build Sasha Levin
2021-04-19 20:44 ` [PATCH AUTOSEL 5.10 21/21] readdir: make sure to verify directory entry for legacy interfaces too Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419204420.6375-7-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).