From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAE16C43470 for ; Mon, 19 Apr 2021 20:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A9D06135F for ; Mon, 19 Apr 2021 20:48:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243123AbhDSUsb (ORCPT ); Mon, 19 Apr 2021 16:48:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:54566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241004AbhDSUq3 (ORCPT ); Mon, 19 Apr 2021 16:46:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 61C4A613ED; Mon, 19 Apr 2021 20:45:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618865121; bh=OA8tR/JWbVQiO1aagRDO5aGsUKFVD4bCapNzA312gwg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R7CzLvQHZ1iCpLg6A/SRxdN6R/KDbkxNZ7FfDVOQkzZIvN2Z0XS7Q2PYhxBtNVpdL 3Vk801yufo4TmWI3N+ZPNK0wdN1An2J350xokc4uy8l67IfiT3c6L4m22wOYdU6od0 apKAmZmimVugkytQY3tAcJ4OE311g+HqrQW3Sh6PE50EdGpIh3EU7npZqeNudSNS41 d5JWEONd/xeRwERql/RDB7ONHtri21OviSVfuGBlbH9HjJeyC2ZhQyv+CWFSINSEEQ IZpo1D90lrYHzlud3iIoq4v9O+0LXGrlxK0uB7Zx31HNMorA2CkByUN9G+LKystYfk 081DpxwUqxWWA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia-Ju Bai , TOTE Robot , Jiri Kosina , Sasha Levin , linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 02/12] HID: alps: fix error return code in alps_input_configured() Date: Mon, 19 Apr 2021 16:45:07 -0400 Message-Id: <20210419204517.6770-2-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210419204517.6770-1-sashal@kernel.org> References: <20210419204517.6770-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jia-Ju Bai [ Upstream commit fa8ba6e5dc0e78e409e503ddcfceef5dd96527f4 ] When input_register_device() fails, no error return code is assigned. To fix this bug, ret is assigned with -ENOENT as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-alps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index f4cf541d13e0..3eddd8f73b57 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c @@ -766,6 +766,7 @@ static int alps_input_configured(struct hid_device *hdev, struct hid_input *hi) if (input_register_device(data->input2)) { input_free_device(input2); + ret = -ENOENT; goto exit; } } -- 2.30.2