From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C3BC433B4 for ; Wed, 21 Apr 2021 17:21:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBCCB6145B for ; Wed, 21 Apr 2021 17:21:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241849AbhDURVe (ORCPT ); Wed, 21 Apr 2021 13:21:34 -0400 Received: from foss.arm.com ([217.140.110.172]:38560 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235562AbhDURVe (ORCPT ); Wed, 21 Apr 2021 13:21:34 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 841051424; Wed, 21 Apr 2021 10:21:00 -0700 (PDT) Received: from bogus (unknown [10.57.52.142]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB36F3F694; Wed, 21 Apr 2021 10:20:58 -0700 (PDT) Date: Wed, 21 Apr 2021 18:20:56 +0100 From: Sudeep Holla To: Marc Zyngier Cc: Lorenzo Pieralisi , Hanjun Guo , dann frazier , Fu Wei , Len Brown , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com, stable@vger.kernel.org, Sudeep Holla Subject: Re: [PATCH 1/2] ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure Message-ID: <20210421172056.n2yoggo5epqwdhtc@bogus> References: <20210421164317.1718831-1-maz@kernel.org> <20210421164317.1718831-2-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421164317.1718831-2-maz@kernel.org> User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org (with stable email fixed, but may need separate posting anyways) On Wed, Apr 21, 2021 at 05:43:16PM +0100, Marc Zyngier wrote: > When failing the driver probe because of invalid firmware properties, > the GTDT driver unmaps the interrupt that it mapped earlier. > > However, it never checks whether the mapping of the interrupt actially > succeeded. Even more, should the firmware report an illegal interrupt > number that overlaps with the GIC SGI range, this can result in an > IPI being unmapped, and subsequent fireworks (as reported by Dann > Frazier). > > Rework the driver to have a slightly saner behaviour and actually > check whether the interrupt has been mapped before unmapping things. > > Reported-by: dann frazier > Fixes: ca9ae5ec4ef0 ("acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver") > Signed-off-by: Marc Zyngier > Link: https://lore.kernel.org/r/YH87dtTfwYgavusz@xps13.dannf > Cc: stable@vgerlkernel.org ^^^ I thought I messed up while replying with my fat fingers, but here is the culprit. I got mail delivery failure to my reply, thought I will let you know as it may be difficult to notice this when using git send-email. -- Regards, Sudeep