From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 671ABC433F5 for ; Mon, 13 Sep 2021 13:54:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5366461209 for ; Mon, 13 Sep 2021 13:54:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244911AbhIMNzw (ORCPT ); Mon, 13 Sep 2021 09:55:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:36596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242838AbhIMNxq (ORCPT ); Mon, 13 Sep 2021 09:53:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 90D3361209; Mon, 13 Sep 2021 13:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540106; bh=48pu5iASxiNMtjVwU7GIi6iA+uGpxSAHybb0FSBURQ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wedvWKnvmefoY554rfILWWde/tdsYktMR2OZVNj1Yg/Wk5HsZWsv+ZzkGdMGIjlyy gZtMaWGcyyaaOIPg/HTLcEqF6/Snh+OFW5NuxWHKRrBCAX5xuH99fa1fN5aghQ4WGh WhVxldJXA+RSRst38B6SZEQevhmIBf+kLTw+uOII= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Mika=20Penttil=C3=A4?= , "Peter Zijlstra (Intel)" , Mel Gorman , Pankaj Gupta , Sasha Levin Subject: [PATCH 5.13 052/300] sched/numa: Fix is_core_idle() Date: Mon, 13 Sep 2021 15:11:53 +0200 Message-Id: <20210913131111.109561750@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Mika Penttilä [ Upstream commit 1c6829cfd3d5124b125e6df41158665aea413b35 ] Use the loop variable instead of the function argument to test the other SMT siblings for idle. Fixes: ff7db0bf24db ("sched/numa: Prefer using an idle CPU as a migration target instead of comparing tasks") Signed-off-by: Mika Penttilä Signed-off-by: Peter Zijlstra (Intel) Acked-by: Mel Gorman Acked-by: Pankaj Gupta Link: https://lkml.kernel.org/r/20210722063946.28951-1-mika.penttila@gmail.com Signed-off-by: Sasha Levin --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index f60ef0b4ec33..3889fee98d11 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1529,7 +1529,7 @@ static inline bool is_core_idle(int cpu) if (cpu == sibling) continue; - if (!idle_cpu(cpu)) + if (!idle_cpu(sibling)) return false; } #endif -- 2.30.2