From: Pavel Machek <pavel@ucw.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Bryan ODonoghue <bryan.odonoghue@linaro.org>,
Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH 5.10 14/16] Revert "wcn36xx: Disable bmps when encryption is disabled"
Date: Fri, 5 Nov 2021 14:18:48 +0100 [thread overview]
Message-ID: <20211105131848.GA9566@amd> (raw)
In-Reply-To: <20211104141200.061783376@linuxfoundation.org>
[-- Attachment #1: Type: text/plain, Size: 2282 bytes --]
Hi!
> From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>
> commit 285bb1738e196507bf985574d0bc1e9dd72d46b1 upstream.
>
> This reverts commit c6522a5076e1a65877c51cfee313a74ef61cabf8.
>
> Testing on tip-of-tree shows that this is working now. Revert this and
> re-enable BMPS for Open APs.
This explains why revert is a good idea for mainline, but it may still
cause problems for 5.10. Is someone able to test it in 5.10?
Best regards,
Pavel
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -601,15 +601,6 @@ static int wcn36xx_set_key(struct ieee80
> }
> }
> }
> - /* FIXME: Only enable bmps support when encryption is enabled.
> - * For any reasons, when connected to open/no-security BSS,
> - * the wcn36xx controller in bmps mode does not forward
> - * 'wake-up' beacons despite AP sends DTIM with station AID.
> - * It could be due to a firmware issue or to the way driver
> - * configure the station.
> - */
> - if (vif->type == NL80211_IFTYPE_STATION)
> - vif_priv->allow_bmps = true;
> break;
> case DISABLE_KEY:
> if (!(IEEE80211_KEY_FLAG_PAIRWISE & key_conf->flags)) {
> @@ -909,7 +900,6 @@ static void wcn36xx_bss_info_changed(str
> vif->addr,
> bss_conf->aid);
> vif_priv->sta_assoc = false;
> - vif_priv->allow_bmps = false;
> wcn36xx_smd_set_link_st(wcn,
> bss_conf->bssid,
> vif->addr,
> --- a/drivers/net/wireless/ath/wcn36xx/pmc.c
> +++ b/drivers/net/wireless/ath/wcn36xx/pmc.c
> @@ -23,10 +23,7 @@ int wcn36xx_pmc_enter_bmps_state(struct
> {
> int ret = 0;
> struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
> -
> - if (!vif_priv->allow_bmps)
> - return -ENOTSUPP;
> -
> + /* TODO: Make sure the TX chain clean */
> ret = wcn36xx_smd_enter_bmps(wcn, vif);
> if (!ret) {
> wcn36xx_dbg(WCN36XX_DBG_PMC, "Entered BMPS\n");
> --- a/drivers/net/wireless/ath/wcn36xx/wcn36xx.h
> +++ b/drivers/net/wireless/ath/wcn36xx/wcn36xx.h
> @@ -127,7 +127,6 @@ struct wcn36xx_vif {
> enum wcn36xx_hal_bss_type bss_type;
>
> /* Power management */
> - bool allow_bmps;
> enum wcn36xx_power_state pw_state;
>
> u8 bss_index;
>
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-11-05 13:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 14:12 [PATCH 5.10 00/16] 5.10.78-rc1 review Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 01/16] scsi: core: Put LLD module refcnt after SCSI device is released Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 02/16] Revert "io_uring: reinforce cancel on flush during exit" Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 03/16] sfc: Fix reading non-legacy supported link modes Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 04/16] vrf: Revert "Reset skb conntrack connection..." Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 05/16] net: ethernet: microchip: lan743x: Fix skb allocation failure Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 06/16] mm: hwpoison: remove the unnecessary THP check Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 07/16] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 08/16] media: firewire: firedtv-avc: fix a buffer overflow in avc_ca_pmt() Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 09/16] Revert "xhci: Set HCD flag to defer primary roothub registration" Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 10/16] Revert "usb: core: hcd: Add support for deferring " Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 11/16] mm: khugepaged: skip huge page collapse for special files Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 12/16] Revert "drm/ttm: fix memleak in ttm_transfered_destroy" Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 13/16] ARM: 9120/1: Revert "amba: make use of -1 IRQs warn" Greg Kroah-Hartman
2021-11-05 13:32 ` Pavel Machek
2021-11-04 14:12 ` [PATCH 5.10 14/16] Revert "wcn36xx: Disable bmps when encryption is disabled" Greg Kroah-Hartman
2021-11-05 13:18 ` Pavel Machek [this message]
2021-11-05 14:06 ` Bryan O'Donoghue
2021-11-04 14:12 ` [PATCH 5.10 15/16] ALSA: usb-audio: Add Schiit Hel device to mixer map quirk table Greg Kroah-Hartman
2021-11-04 14:12 ` [PATCH 5.10 16/16] ALSA: usb-audio: Add Audient iD14 " Greg Kroah-Hartman
2021-11-04 15:53 ` [PATCH 5.10 00/16] 5.10.78-rc1 review Daniel Díaz
2021-11-04 16:20 ` Greg Kroah-Hartman
2021-11-04 16:45 ` Daniel Díaz
2021-11-04 16:46 ` Guenter Roeck
2021-11-04 16:52 ` Greg Kroah-Hartman
2021-11-04 18:38 ` Fox Chen
2021-11-04 23:48 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211105131848.GA9566@amd \
--to=pavel@ucw.cz \
--cc=bryan.odonoghue@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).