From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BE53C433EF for ; Tue, 9 Nov 2021 22:43:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7459C61075 for ; Tue, 9 Nov 2021 22:43:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345755AbhKIWqD (ORCPT ); Tue, 9 Nov 2021 17:46:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:36028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346084AbhKIWnl (ORCPT ); Tue, 9 Nov 2021 17:43:41 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 37C3661279; Tue, 9 Nov 2021 22:24:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636496669; bh=AF5rWGo5YP66H58UWowbIAxu4mTrCMaInaWsDvMma0A=; h=From:To:Cc:Subject:Date:From; b=YeJxukc+VkqgyvF8TTzy0wHB4nMu+FlL8rQAfwMzCEyYFKqjpMHeGual7a2/vnRtk OdlhE+i60Ts8RQv9IxX1E6+8i+Yre8fvT4Zlahf3tnKkzZNb7L6nBDsMOL7tOn5r+7 nPVKdGpo2NxYq4X7QOvbbo+67OAyw4wk79GQbFqnKKabWUb0nImkfkDR7K/y8TNhrF uJhxgSCqn0ztGdnXAaEqXebz3hosw1n4cs4FnQZpaOMP0bgBGMDkIujjH0RELmFHvh iBUrD/HN0WJAE25Fk74/srJlPg46d0p0SrytBHjbKL6x0GIMeccZ4LY1qHDIBWCLC+ FqOHG2xrPQCNQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: James Smart , Justin Tee , "Martin K . Petersen" , Sasha Levin , james.smart@avagotech.com, dick.kennedy@avagotech.com, JBottomley@odin.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 01/12] scsi: lpfc: Fix list_add() corruption in lpfc_drain_txq() Date: Tue, 9 Nov 2021 17:24:15 -0500 Message-Id: <20211109222426.1236575-1-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: James Smart [ Upstream commit 99154581b05c8fb22607afb7c3d66c1bace6aa5d ] When parsing the txq list in lpfc_drain_txq(), the driver attempts to pass the requests to the adapter. If such an attempt fails, a local "fail_msg" string is set and a log message output. The job is then added to a completions list for cancellation. Processing of any further jobs from the txq list continues, but since "fail_msg" remains set, jobs are added to the completions list regardless of whether a wqe was passed to the adapter. If successfully added to txcmplq, jobs are added to both lists resulting in list corruption. Fix by clearing the fail_msg string after adding a job to the completions list. This stops the subsequent jobs from being added to the completions list unless they had an appropriate failure. Link: https://lore.kernel.org/r/20210910233159.115896-2-jsmart2021@gmail.com Co-developed-by: Justin Tee Signed-off-by: Justin Tee Signed-off-by: James Smart Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/lpfc/lpfc_sli.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 9055a8fce3d4a..2087125922a11 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -17071,6 +17071,7 @@ lpfc_drain_txq(struct lpfc_hba *phba) fail_msg, piocbq->iotag, piocbq->sli4_xritag); list_add_tail(&piocbq->list, &completions); + fail_msg = NULL; } spin_unlock_irqrestore(&pring->ring_lock, iflags); } -- 2.33.0