From: Jakub Kicinski <kuba@kernel.org>
To: Tadeusz Struk <tadeusz.struk@linaro.org>
Cc: jmaloy@redhat.com, Ying Xue <ying.xue@windriver.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH] tipc: check for null after calling kmemdup
Date: Fri, 12 Nov 2021 20:08:28 -0800 [thread overview]
Message-ID: <20211112200828.50049d76@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20211111205916.37899-1-tadeusz.struk@linaro.org>
On Thu, 11 Nov 2021 12:59:15 -0800 Tadeusz Struk wrote:
> kmemdup can return a null pointer so need to check for it, otherwise
> the null key will be dereferenced later in tipc_crypto_key_xmit as
> can be seen in the trace [1].
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@linaro.org>
Fixes: 1ef6f7c9390f ("tipc: add automatic session key exchange")
prev parent reply other threads:[~2021-11-13 4:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 20:59 [PATCH] tipc: check for null after calling kmemdup Tadeusz Struk
2021-11-12 0:06 ` Jon Maloy
2021-11-13 4:13 ` Jakub Kicinski
2021-11-13 5:42 ` Tadeusz Struk
2021-11-16 19:32 ` Jakub Kicinski
2021-11-16 19:33 ` Jakub Kicinski
2021-11-13 4:08 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211112200828.50049d76@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=jmaloy@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tadeusz.struk@linaro.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).