From: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>
To: Sasha Levin <sashal@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
jgross@suse.com, x86@kernel.org, pv-drivers@vmware.com,
Alexey Makhalov <amakhalov@vmware.com>,
Deep Shah <sdeep@vmware.com>,
stable@vger.kernel.org,
virtualization@lists.linux-foundation.org, keerthanak@vmware.com,
srivatsab@vmware.com, anishs@vmware.com, vithampi@vmware.com,
linux-kernel@vger.kernel.org, namit@vmware.com, joe@perches.com,
kuba@kernel.org, rostedt@goodmis.org
Subject: Re: [PATCH v3 1/3] MAINTAINERS: Update maintainers for paravirt ops and VMware hypervisor interface
Date: Mon, 15 Nov 2021 14:39:00 -0800 [thread overview]
Message-ID: <20211115223900.GA22267@csail.mit.edu> (raw)
In-Reply-To: <YY6hhWtvh+OvOqAl@sashalap>
On Fri, Nov 12, 2021 at 12:16:53PM -0500, Sasha Levin wrote:
> On Thu, Nov 11, 2021 at 11:40:02AM -0800, Srivatsa S. Bhat wrote:
> > On Thu, Nov 11, 2021 at 07:45:02PM +0100, Greg KH wrote:
> > > On Thu, Nov 11, 2021 at 07:39:16AM -0800, Srivatsa S. Bhat wrote:
> > > > On Thu, Nov 11, 2021 at 07:50:39AM +0100, Greg KH wrote:
> > > > > On Wed, Nov 10, 2021 at 12:08:16PM -0800, Srivatsa S. Bhat wrote:
> > > > > > From: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>
> > > > > >
> > > > > > Deep has decided to transfer maintainership of the VMware hypervisor
> > > > > > interface to Srivatsa, and the joint-maintainership of paravirt ops in
> > > > > > the Linux kernel to Srivatsa and Alexey. Update the MAINTAINERS file
> > > > > > to reflect this change.
> > > > > >
> > > > > > Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>
> > > > > > Acked-by: Alexey Makhalov <amakhalov@vmware.com>
> > > > > > Acked-by: Deep Shah <sdeep@vmware.com>
> > > > > > Acked-by: Juergen Gross <jgross@suse.com>
> > > > > > Cc: stable@vger.kernel.org
> > > > >
> > > > > Why are MAINTAINERS updates needed for stable? That's not normal :(
> > > >
> > > > So that people posting bug-fixes / backports to these subsystems for
> > > > older kernels (stable and LTS releases) will CC the new subsystem
> > > > maintainers.
> > >
> > > That's not how stable releases work at all.
> > >
> > > > That's why I added CC stable tag only to the first two
> > > > patches which add/replace maintainers and not the third patch which is
> > > > just a cleanup.
> > >
> > > Patches for stable kernels need to go into Linus's tree first, and if
> > > you have the MAINTAINERS file updated properly there, then you will be
> > > properly cc:ed. We do not look at the MAINTAINERS file for the older
> > > kernel when sending patches out, it's totally ignored as that was the
> > > snapshot at a point in time, which is usually no longer the true state.
> > >
> >
> > Sure, but that's the case for patches that get mainlined (and
> > subsequently backported to -stable) /after/ this update to the
> > MAINTAINERS file gets merged into mainline.
> >
> > When adding the CC stable tag, the case I was trying to address was
> > for patches that are already in mainline but weren't CC'ed to stable,
> > and at some later point, somebody decides to backport them to older
> > stable kernels. In that case, there is a chance that the contributor
> > might run ./get_maintainer.pl against the stable tree (as that's the
> > tree they are backporting the upstream commit against) and end up not
> > CC'ing the new maintainers. So, I thought it would be good to keep the
> > maintainer info updated in the older stable kernels too.
>
> If you look at cases like these, I can see an argument around bringing
> it back to -stable. However, changes in the upstream MAINTAINERS file
> aren't limited to just change in maintainers.
>
> How would we handle addition of maintainers of a new code upstream? Or
> removal of maintainers due to code deletion? Or code movement upstream
> that isn't reflected in the stable tree (think a driver graduating from
> staging).
>
Good point!
> It becomes a mess quite quickly and the easiest solution here is to just
> use upstream's MAINTAINERS file.
>
Agreed.
> Maybe we should just remove MAINTAINERS from stable trees to make it
> obvious.
>
I don't think we should go quite that far. Instead, perhaps we can
modify get_maintainer.pl (if needed) such that it prints out a warning
or reminder to consult the upstream MAINTAINERS file if the script is
invoked on an older stable kernel.
Regards,
Srivatsa
next prev parent reply other threads:[~2021-11-15 22:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 20:07 [PATCH v3 0/3] Update VMware maintainer entries Srivatsa S. Bhat
2021-11-10 20:08 ` [PATCH v3 1/3] MAINTAINERS: Update maintainers for paravirt ops and VMware hypervisor interface Srivatsa S. Bhat
2021-11-11 6:50 ` Greg KH
2021-11-11 13:57 ` Steven Rostedt
2021-11-11 15:39 ` Srivatsa S. Bhat
2021-11-11 18:45 ` Greg KH
2021-11-11 19:40 ` Srivatsa S. Bhat
2021-11-12 6:55 ` Greg KH
2021-11-12 17:31 ` Srivatsa S. Bhat
2021-11-12 17:16 ` Sasha Levin
2021-11-15 22:39 ` Srivatsa S. Bhat [this message]
2021-11-16 4:33 ` Joe Perches
2021-11-16 18:18 ` Srivatsa S. Bhat
2021-11-16 23:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115223900.GA22267@csail.mit.edu \
--to=srivatsa@csail.mit.edu \
--cc=amakhalov@vmware.com \
--cc=anishs@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgross@suse.com \
--cc=joe@perches.com \
--cc=keerthanak@vmware.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namit@vmware.com \
--cc=pv-drivers@vmware.com \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=sdeep@vmware.com \
--cc=srivatsab@vmware.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=vithampi@vmware.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).