stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Meng Li <Meng.Li@windriver.com>
To: stable@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
	mcoquelin.stm32@gmail.com, linux@armlinux.org.uk, andrew@lunn.ch,
	qiangqing.zhang@nxp.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	meng.li@windriver.com
Subject: [PATCH 0/6] backport patches to improve clocks management for stmmac driver
Date: Fri, 19 Nov 2021 10:53:53 +0800	[thread overview]
Message-ID: <20211119025359.30815-1-Meng.Li@windriver.com> (raw)

From: Meng Li <meng.li@windriver.com>

In stable kernel v5.10, when run below command to remove ethernet driver on
stratix10 platform, there will be warning trace as below:

$ cd /sys/class/net/eth0/device/driver/
$ echo ff800000.ethernet > unbind

WARNING: CPU: 3 PID: 386 at drivers/clk/clk.c:810 clk_core_unprepare+0x114/0x274
Modules linked in: sch_fq_codel
CPU: 3 PID: 386 Comm: sh Tainted: G        W         5.10.74-yocto-standard #1
Hardware name: SoCFPGA Stratix 10 SoCDK (DT)
pstate: 00000005 (nzcv daif -PAN -UAO -TCO BTYPE=--)
pc : clk_core_unprepare+0x114/0x274
lr : clk_core_unprepare+0x114/0x274
sp : ffff800011bdbb10
clk_core_unprepare+0x114/0x274
 clk_unprepare+0x38/0x50
 stmmac_remove_config_dt+0x40/0x80
 stmmac_pltfr_remove+0x64/0x80
 platform_drv_remove+0x38/0x60
 ... ..
 el0_sync_handler+0x1a4/0x1b0
 el0_sync+0x180/0x1c0
This issue is introduced by introducing upstream commit 8f269102baf7
("net: stmmac: disable clocks in stmmac_remove_config_dt()")

But in latest mainline kernel, there is no this issue. Because commit
5ec55823438e("net: stmmac: add clocks management for gmac driver") and its
folowing fixing commits improved clocks management for stmmac driver.
Therefore, backport them to stable kernel v5.10.


Joakim Zhang (2):
  net: stmmac: add clocks management for gmac driver
  net: stmmac: fix system hang if change mac address after interface
    ifdown

Michael Riesch (1):
  net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings

Wei Yongjun (1):
  net: stmmac: platform: fix build error with !CONFIG_PM_SLEEP

Wong Vee Khee (1):
  net: stmmac: fix issue where clk is being unprepared twice

Yang Yingliang (1):
  net: stmmac: fix missing unlock on error in stmmac_suspend()

 .../net/ethernet/stmicro/stmmac/dwmac-rk.c    |   9 --
 drivers/net/ethernet/stmicro/stmmac/stmmac.h  |   1 +
 .../net/ethernet/stmicro/stmmac/stmmac_main.c |  87 ++++++++++++--
 .../net/ethernet/stmicro/stmmac/stmmac_mdio.c | 111 ++++++++++++++----
 .../ethernet/stmicro/stmmac/stmmac_platform.c |  30 ++++-
 5 files changed, 187 insertions(+), 51 deletions(-)

-- 
2.17.1


             reply	other threads:[~2021-11-19  2:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  2:53 Meng Li [this message]
2021-11-19  2:53 ` [PATCH 1/6] net: stmmac: add clocks management for gmac driver Meng Li
2021-11-19  2:53 ` [PATCH 2/6] net: stmmac: platform: fix build error with !CONFIG_PM_SLEEP Meng Li
2021-11-19  2:53 ` [PATCH 3/6] net: stmmac: fix missing unlock on error in stmmac_suspend() Meng Li
2021-11-19  2:53 ` [PATCH 4/6] net: stmmac: fix system hang if change mac address after interface ifdown Meng Li
2021-11-19  2:53 ` [PATCH 5/6] net: stmmac: fix issue where clk is being unprepared twice Meng Li
2021-11-19  2:53 ` [PATCH 6/6] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings Meng Li
2021-11-19 13:29 ` [PATCH 0/6] backport patches to improve clocks management for stmmac driver Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211119025359.30815-1-Meng.Li@windriver.com \
    --to=meng.li@windriver.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=qiangqing.zhang@nxp.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).