From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD142C433F5 for ; Wed, 15 Dec 2021 17:28:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238078AbhLOR2F (ORCPT ); Wed, 15 Dec 2021 12:28:05 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:47380 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343657AbhLOR0n (ORCPT ); Wed, 15 Dec 2021 12:26:43 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 588ED61A05; Wed, 15 Dec 2021 17:26:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C763C36AE0; Wed, 15 Dec 2021 17:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1639589202; bh=ijfdEIMXipzfofjjcBwYmFaTIINZkUL3W1yDWk+poaM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z1WlBOpEF1Rxb8l5JroIp/cfRGirb3R+idYu+dpKgHBa1zwF2yz++8vHaumHl1v1A VRrl+q23R1I1O0G8D70YFf5pCjUha4xH3YYyQusX6wIsDjMQ3pr6jqNQ4qBjZBUM2N uQ6jbZFAzbZQ91v4/g1Oj/MP+9jHOZWO+cyWAfQM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jun Lei , Bhawanpreet Lakha , Mustapha Ghaddar , Daniel Wheeler , Alex Deucher , Sasha Levin Subject: [PATCH 5.4 07/18] drm/amd/display: Fix for the no Audio bug with Tiled Displays Date: Wed, 15 Dec 2021 18:21:28 +0100 Message-Id: <20211215172023.064501876@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211215172022.795825673@linuxfoundation.org> References: <20211215172022.795825673@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Mustapha Ghaddar [ Upstream commit 5ceaebcda9061c04f439c93961f0819878365c0f ] [WHY] It seems like after a series of plug/unplugs we end up in a situation where tiled display doesnt support Audio. [HOW] The issue seems to be related to when we check streams changed after an HPD, we should be checking the audio_struct as well to see if any of its values changed. Reviewed-by: Jun Lei Acked-by: Bhawanpreet Lakha Signed-off-by: Mustapha Ghaddar Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c index f25ac17f47fa9..95a5310e9e661 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c @@ -1546,6 +1546,10 @@ bool dc_is_stream_unchanged( if (old_stream->ignore_msa_timing_param != stream->ignore_msa_timing_param) return false; + // Only Have Audio left to check whether it is same or not. This is a corner case for Tiled sinks + if (old_stream->audio_info.mode_count != stream->audio_info.mode_count) + return false; + return true; } -- 2.33.0