From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Benjamin Tissoires <benjamin.tissoires@redhat.com> Subject: [PATCH 4.9 03/19] HID: holtek: fix mouse probing Date: Mon, 27 Dec 2021 16:27:05 +0100 [thread overview] Message-ID: <20211227151316.666094429@linuxfoundation.org> (raw) In-Reply-To: <20211227151316.558965545@linuxfoundation.org> From: Benjamin Tissoires <benjamin.tissoires@redhat.com> commit 93a2207c254ca102ebbdae47b00f19bbfbfa7ecd upstream. An overlook from the previous commit: we don't even parse or start the device, meaning that the device is not presented to user space. Fixes: 93020953d0fa ("HID: check for valid USB device for many HID drivers") Cc: stable@vger.kernel.org Link: https://bugs.archlinux.org/task/73048 Link: https://bugzilla.kernel.org/show_bug.cgi?id=215341 Link: https://lore.kernel.org/r/e4efbf13-bd8d-0370-629b-6c80c0044b15@leemhuis.info/ Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/hid/hid-holtek-mouse.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) --- a/drivers/hid/hid-holtek-mouse.c +++ b/drivers/hid/hid-holtek-mouse.c @@ -68,8 +68,23 @@ static __u8 *holtek_mouse_report_fixup(s static int holtek_mouse_probe(struct hid_device *hdev, const struct hid_device_id *id) { + int ret; + if (!hid_is_usb(hdev)) return -EINVAL; + + ret = hid_parse(hdev); + if (ret) { + hid_err(hdev, "hid parse failed: %d\n", ret); + return ret; + } + + ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT); + if (ret) { + hid_err(hdev, "hw start failed: %d\n", ret); + return ret; + } + return 0; }
next prev parent reply other threads:[~2021-12-27 15:28 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-27 15:27 [PATCH 4.9 00/19] 4.9.295-rc1 review Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 01/19] net: usb: lan78xx: add Allied Telesis AT29M2-AF Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 02/19] can: kvaser_usb: get CAN clock frequency from device Greg Kroah-Hartman 2021-12-27 15:27 ` Greg Kroah-Hartman [this message] 2021-12-27 15:27 ` [PATCH 4.9 04/19] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts() Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 05/19] qlcnic: potential dereference null pointer of rx_queue->page_ring Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 06/19] bonding: fix ad_actor_system option setting to default Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 07/19] fjes: Check for error irq Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 08/19] drivers: net: smc911x: " Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 09/19] hwmon: (lm90) Fix usage of CONFIG2 register in detect function Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 10/19] ALSA: jack: Check the return value of kstrdup() Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 11/19] ALSA: drivers: opl3: Fix incorrect use of vp->state Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 12/19] x86/pkey: Fix undefined behaviour with PKRU_WD_BIT Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 13/19] ARM: 9169/1: entry: fix Thumb2 bug in iWMMXt exception handling Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 14/19] Input: i8042 - enable deferred probe quirk for ASUS UM325UA Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 15/19] hwmon: (lm90) Do not report busy status bit as alarm Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 16/19] ax25: NPD bug when detaching AX25 device Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 17/19] hamradio: defer ax25 kfree after unregister_netdev Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 18/19] hamradio: improve the incomplete fix to avoid NPD Greg Kroah-Hartman 2021-12-27 15:27 ` [PATCH 4.9 19/19] phonet/pep: refuse to enable an unbound pipe Greg Kroah-Hartman 2021-12-27 17:26 ` [PATCH 4.9 00/19] 4.9.295-rc1 review Florian Fainelli 2021-12-28 17:05 ` Guenter Roeck 2021-12-28 17:12 ` Naresh Kamboju 2021-12-28 21:30 ` Shuah Khan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211227151316.666094429@linuxfoundation.org \ --to=gregkh@linuxfoundation.org \ --cc=benjamin.tissoires@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=stable@vger.kernel.org \ --subject='Re: [PATCH 4.9 03/19] HID: holtek: fix mouse probing' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).