From: Naohiro Aota <Naohiro.Aota@wdc.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: "damien.lemoal@opensource.wdc.com"
<damien.lemoal@opensource.wdc.com>,
"David.Laight@ACULAB.COM" <David.Laight@ACULAB.COM>,
"davem@davemloft.net" <davem@davemloft.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap
Date: Tue, 11 Jan 2022 02:23:29 +0000 [thread overview]
Message-ID: <20220111022328.ynoyoekjwwf6p2vw@naota-xeon> (raw)
In-Reply-To: <20220109140142.4081651-1-jiasheng@iscas.ac.cn>
On Sun, Jan 09, 2022 at 10:01:42PM +0800, Jiasheng Jiang wrote:
> On Sun, Jan 09, 2022 at 04:53:39PM +0800, Damien Le Moal wrote:
> >>>> Cc: stable@vger.kernel.org#5.10
> >>>
> >>> Please keep the space before the #
> >>>
> >>> Cc: stable@vger.kernel.org #5.10
> >>
> >> Actually, I added the space before, but the when I use the tool
> >> 'scripts/checkpatch.pl' to check my format, it told me a warning
> >> that it should not have space.
> >>
> >> The warning is as follow:
> >> WARNING: email address 'stable@vger.kernel.org #5.10' might be
> >> better as 'stable@vger.kernel.org#5.10'
> >
> > Cc: stable@vger.kernel.org # 5.10
> >
> > Should work.
>
> I used 'scripts/checkpatch.pl' to check it, giving me the warning again.
>
> The warning is as follow:
> WARNING: email address 'stable@vger.kernel.org # 5.10' might be better as
> 'stable@vger.kernel.org# 5.10'
>
> And if I use the 'stable@vger.kernel.org# 5.10', warning too.
>
> The warning is as follow:
> WARNING: email address 'stable@vger.kernel.org# 5.10' might be better as
> 'stable@vger.kernel.org#5.10'
>
> It seems that the only non-warning format is 'stable@vger.kernel.org#5.10'.
>
> Sincerely thanks,
> Jiang
>
The checkpatch.pl in 5.10.90 fails to parse the line as shown
above. That is fixed in commit fccaebf00e60 ("checkpatch: improve
email parsing") in the current tree.
next prev parent reply other threads:[~2022-01-11 2:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 14:01 Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap Jiasheng Jiang
2022-01-11 2:23 ` Naohiro Aota [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-11 3:01 Jiasheng Jiang
2022-01-08 3:55 Jiasheng Jiang
2022-01-09 8:53 ` Damien Le Moal
2022-01-07 12:53 Jiasheng Jiang
2022-01-08 2:53 ` Damien Le Moal
2022-01-07 11:50 Jiasheng Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111022328.ynoyoekjwwf6p2vw@naota-xeon \
--to=naohiro.aota@wdc.com \
--cc=David.Laight@ACULAB.COM \
--cc=damien.lemoal@opensource.wdc.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).