From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F669C4332F for ; Fri, 14 Jan 2022 08:21:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239912AbiANIVE (ORCPT ); Fri, 14 Jan 2022 03:21:04 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:59256 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239918AbiANIUP (ORCPT ); Fri, 14 Jan 2022 03:20:15 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DBA7361E03; Fri, 14 Jan 2022 08:20:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C36F7C36AEA; Fri, 14 Jan 2022 08:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1642148414; bh=5uYvaj/o8FSbuW51F4u+/4dDvv0Mwq76hIX63flRWg0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Quqkh8eTyzOqbgN7JEBXIg3BuIn5a7I8rm2wTnwiD476E33DFKr+5w+IOCfZKKmtH T7axuswLNGDUwt1O8vbvkjpNo6tmOfGn7exGgnvjsn+d2gy7NoCh7jI5OBxfFbh8Vr iza8rbxpzrVc/IP/1+2rCIaEc4uznnGHvP0zxlt0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Martin Kaiser Subject: [PATCH 5.15 03/41] staging: r8188eu: switch the led off during deinit Date: Fri, 14 Jan 2022 09:16:03 +0100 Message-Id: <20220114081545.274454653@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220114081545.158363487@linuxfoundation.org> References: <20220114081545.158363487@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Martin Kaiser commit 9d36de31130542fc060f7cd17e72db670202c682 upstream. When the driver is unloaded or when the system goes into standby mode, DeInitLed871x is called to stop the led layer. In this case, we stop the blinking worker but we do not switch the led off explicitly. On my system, I can go into standby mode with the LED enabled. Add a call to SwLedOff to fix this. Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver") Cc: stable@vger.kernel.org Signed-off-by: Martin Kaiser Link: https://lore.kernel.org/r/20211226195556.159471-2-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman --- drivers/staging/r8188eu/core/rtw_led.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/staging/r8188eu/core/rtw_led.c +++ b/drivers/staging/r8188eu/core/rtw_led.c @@ -74,6 +74,7 @@ void DeInitLed871x(struct LED_871x *pLed _cancel_workitem_sync(&pLed->BlinkWorkItem); _cancel_timer_ex(&pLed->BlinkTimer); ResetLedStatus(pLed); + SwLedOff(pLed->padapter, pLed); } /* */