stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
	Marcel Holtmann <marcel@holtmann.org>,
	Sasha Levin <sashal@kernel.org>,
	johan.hedberg@gmail.com, luiz.dentz@gmail.com,
	davem@davemloft.net, kuba@kernel.org,
	linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH AUTOSEL 4.19 01/59] Bluetooth: Fix debugfs entry leak in hci_register_dev()
Date: Mon, 17 Jan 2022 21:46:02 -0500	[thread overview]
Message-ID: <20220118024701.1952911-1-sashal@kernel.org> (raw)

From: Wei Yongjun <weiyongjun1@huawei.com>

[ Upstream commit 5a4bb6a8e981d3d0d492aa38412ee80b21033177 ]

Fault injection test report debugfs entry leak as follows:

debugfs: Directory 'hci0' with parent 'bluetooth' already present!

When register_pm_notifier() failed in hci_register_dev(), the debugfs
create by debugfs_create_dir() do not removed in the error handing path.

Add the remove debugfs code to fix it.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 net/bluetooth/hci_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 26acacb2fa95f..a5755e0645439 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -3263,6 +3263,7 @@ int hci_register_dev(struct hci_dev *hdev)
 	return id;
 
 err_wqueue:
+	debugfs_remove_recursive(hdev->debugfs);
 	destroy_workqueue(hdev->workqueue);
 	destroy_workqueue(hdev->req_workqueue);
 err:
-- 
2.34.1


             reply	other threads:[~2022-01-18  3:04 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18  2:46 Sasha Levin [this message]
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 02/59] fs: dlm: filter user dlm messages for kernel locks Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 03/59] ar5523: Fix null-ptr-deref with unexpected WDCMSG_TARGET_START reply Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 04/59] drm/nouveau/pmu/gm200-: avoid touching PMU outside of DEVINIT/PREOS/ACR Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 05/59] usb: gadget: f_fs: Use stream_open() for endpoint files Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 06/59] HID: apple: Do not reset quirks when the Fn key is not found Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 07/59] media: b2c2: Add missing check in flexcop_pci_isr: Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 08/59] ARM: imx: rename DEBUG_IMX21_IMX27_UART to DEBUG_IMX27_UART Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 09/59] mlxsw: pci: Add shutdown method in PCI driver Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 10/59] drm/bridge: megachips: Ensure both bridges are probed before registration Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 11/59] gpiolib: acpi: Do not set the IRQ type if the IRQ is already in use Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 12/59] HSI: core: Fix return freed object in hsi_new_client Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 13/59] mwifiex: Fix skb_over_panic in mwifiex_usb_recv() Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 14/59] rsi: Fix out-of-bounds read in rsi_read_pkt() Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 15/59] usb: uhci: add aspeed ast2600 uhci support Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 16/59] floppy: Add max size check for user space request Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 17/59] media: uvcvideo: Increase UVC_CTRL_CONTROL_TIMEOUT to 5 seconds Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 18/59] media: saa7146: hexium_orion: Fix a NULL pointer dereference in hexium_attach() Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 19/59] media: m920x: don't use stack on USB reads Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 20/59] iwlwifi: mvm: synchronize with FW after multicast commands Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 21/59] ath10k: Fix tx hanging Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 22/59] net-sysfs: update the queue counts in the unregistration path Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 23/59] net: Enable neighbor sysctls that is save for userns root Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 24/59] x86/mce: Mark mce_panic() noinstr Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 25/59] x86/mce: Mark mce_end() noinstr Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 26/59] x86/mce: Mark mce_read_aux() noinstr Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 27/59] net: bonding: debug: avoid printing debug logs when bond is not notifying peers Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 28/59] bpf: Do not WARN in bpf_warn_invalid_xdp_action() Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 29/59] HID: quirks: Allow inverting the absolute X/Y values Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 30/59] media: igorplugusb: receiver overflow should be reported Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 31/59] media: saa7146: hexium_gemini: Fix a NULL pointer dereference in hexium_attach() Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 32/59] mmc: core: Fixup storing of OCR for MMC_QUIRK_NONSTD_SDIO Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 33/59] audit: ensure userspace is penalized the same as the kernel when under pressure Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 34/59] arm64: tegra: Adjust length of CCPLEX cluster MMIO region Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 35/59] usb: hub: Add delay for SuperSpeed hub resume to let links transit to U0 Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 36/59] ath9k: Fix out-of-bound memcpy in ath9k_hif_usb_rx_stream Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 37/59] iwlwifi: fix leaks/bad data after failed firmware load Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 38/59] iwlwifi: remove module loading failure message Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 39/59] iwlwifi: mvm: Fix calculation of frame length Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 40/59] um: registers: Rename function names to avoid conflicts and build problems Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 41/59] jffs2: GC deadlock reading a page that is used in jffs2_write_begin() Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 42/59] ACPICA: actypes.h: Expand the ACPI_ACCESS_ definitions Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 43/59] ACPICA: Utilities: Avoid deleting the same object twice in a row Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 44/59] ACPICA: Executer: Fix the REFCLASS_REFOF case in acpi_ex_opcode_1A_0T_1R() Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 45/59] ACPICA: Hardware: Do not flush CPU cache when entering S4 and S5 Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 46/59] drm/amdgpu: fixup bad vram size on gmc v8 Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 47/59] ACPI: battery: Add the ThinkPad "Not Charging" quirk Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 48/59] btrfs: remove BUG_ON() in find_parent_nodes() Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 49/59] btrfs: remove BUG_ON(!eie) in find_parent_nodes Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 50/59] net: mdio: Demote probed message to debug print Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 51/59] mac80211: allow non-standard VHT MCS-10/11 Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 52/59] dm btree: add a defensive bounds check to insert_at() Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 53/59] dm space map common: add bounds check to sm_ll_lookup_bitmap() Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 54/59] net: phy: marvell: configure RGMII delays for 88E1118 Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 55/59] net: gemini: allow any RGMII interface mode Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 56/59] regulator: qcom_smd: Align probe function with rpmh-regulator Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 57/59] serial: pl010: Drop CR register reset on set_termios Sasha Levin
2022-01-18  2:46 ` [PATCH AUTOSEL 4.19 58/59] serial: core: Keep mctrl register state and cached copy in sync Sasha Levin
2022-01-18  2:47 ` [PATCH AUTOSEL 4.19 59/59] parisc: Avoid calling faulthandler_disabled() twice Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220118024701.1952911-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=davem@davemloft.net \
    --cc=johan.hedberg@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).