From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Max Kellermann <max.kellermann@gmail.com>
Cc: linux-pwm@vger.kernel.org, thierry.reding@gmail.com,
lee.jones@linaro.org, linux-kernel@vger.kernel.org,
andrey@lebedev.lt, stable@vger.kernel.org
Subject: Re: [PATCH 1/3] pwm-sun4i: convert "next_period" to local variable
Date: Tue, 25 Jan 2022 15:31:58 +0100 [thread overview]
Message-ID: <20220125143158.qbelqvr5mjq33zay@pengutronix.de> (raw)
In-Reply-To: <20220125123429.3490883-1-max.kellermann@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
Hello,
On Tue, Jan 25, 2022 at 01:34:27PM +0100, Max Kellermann wrote:
> Its value is calculated in sun4i_pwm_apply() and is used only there.
>
> Cc: stable@vger.kernel.org
I think I'd drop this. This isn't a fix worth on it's own to be
backported and if this is needed for one of the next patches, the stable
maintainers will notice themselves (and it might be worth to shuffle
this series to make the fixes come first).
> Signed-off-by: Max Kellermann <max.kellermann@gmail.com>
Other than that, LGTM:
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-01-25 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 12:34 [PATCH 1/3] pwm-sun4i: convert "next_period" to local variable Max Kellermann
2022-01-25 12:34 ` [PATCH 2/3] pwm-sun4i: calculate "delay_jiffies" directly, eliminate absolute time Max Kellermann
2022-02-24 16:50 ` Uwe Kleine-König
2022-01-25 12:34 ` [PATCH 3/3] pwm-sun4i: calculate the delay without rounding down to jiffies Max Kellermann
2022-02-24 16:51 ` Uwe Kleine-König
2022-03-03 21:56 ` Uwe Kleine-König
2022-01-25 14:31 ` Uwe Kleine-König [this message]
2022-01-25 14:39 ` [PATCH 1/3] pwm-sun4i: convert "next_period" to local variable Max Kellermann
2022-01-25 14:43 ` Uwe Kleine-König
2022-02-24 13:04 ` Thierry Reding
2022-02-24 16:49 ` Uwe Kleine-König
2022-04-22 15:47 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125143158.qbelqvr5mjq33zay@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=andrey@lebedev.lt \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=max.kellermann@gmail.com \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).