From: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 6/8] drm/i915: Fix PSF GV point mask when SAGV is not possible
Date: Wed, 9 Mar 2022 21:34:58 +0200 [thread overview]
Message-ID: <20220309193458.GA9556@intel.com> (raw)
In-Reply-To: <Yij7HFOvBiVg+kqD@intel.com>
On Wed, Mar 09, 2022 at 09:08:12PM +0200, Ville Syrjälä wrote:
> On Wed, Mar 09, 2022 at 08:59:59PM +0200, Lisovskiy, Stanislav wrote:
> > On Wed, Mar 09, 2022 at 06:49:46PM +0200, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Don't just mask off all the PSF GV points when SAGV gets disabled.
> > > This should in fact cause the Pcode to reject the request since
> > > at least one PSF point must remain enabled at all times.
> >
> > Good point, however I think this is not the full fix:
> >
> > BSpec says:
> >
> > "At least one GV point of each type must always remain unmasked."
> >
> > and
> >
> > "The GV point of each type providing the highest bandwidth
> > for display must always remain unmasked."
> >
> > So I guess we should then also choose thr PSF GV point with
> > the highest bandwidth as well.
>
> The spec says PSF GV is fast enough to now stall the display data
> fetch so we don't need to restrict the PSF points here.
But why it asks to ensure that we have the PSF GV of highest bandwidth to
stay always unmasked then?
Stan
>
> --
> Ville Syrjälä
> Intel
next prev parent reply other threads:[~2022-03-09 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220309164948.10671-1-ville.syrjala@linux.intel.com>
2022-03-09 16:49 ` [PATCH v2 1/8] drm/i915: Treat SAGV block time 0 as SAGV disabled Ville Syrjala
2022-03-09 19:29 ` [Intel-gfx] " Lisovskiy, Stanislav
2022-03-09 20:35 ` Ville Syrjälä
2022-03-16 17:55 ` Lisovskiy, Stanislav
2022-03-09 16:49 ` [PATCH v2 6/8] drm/i915: Fix PSF GV point mask when SAGV is not possible Ville Syrjala
2022-03-09 18:59 ` Lisovskiy, Stanislav
2022-03-09 19:08 ` Ville Syrjälä
2022-03-09 19:34 ` Lisovskiy, Stanislav [this message]
2022-03-09 20:21 ` Ville Syrjälä
2022-03-16 18:01 ` [Intel-gfx] " Lisovskiy, Stanislav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309193458.GA9556@intel.com \
--to=stanislav.lisovskiy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).