From: Jakub Kicinski <kuba@kernel.org>
To: "Stéphane Graber" <stgraber@ubuntu.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Iyappan Subramanian <iyappan@os.amperecomputing.com>,
Keyur Chudgar <keyur@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>,
"David S . Miller" <davem@davemloft.net>,
Toan Le <toan@os.amperecomputing.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] drivers: net: xgene: Fix regression in CRC stripping
Date: Fri, 18 Mar 2022 14:12:07 -0700 [thread overview]
Message-ID: <20220318141207.284972b7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20220317144225.4005500-1-stgraber@ubuntu.com>
On Thu, 17 Mar 2022 10:42:25 -0400 Stéphane Graber wrote:
> From: Stephane Graber <stgraber@ubuntu.com>
>
> All packets on ingress (except for jumbo) are terminated with a 4-bytes
> CRC checksum. It's the responsability of the driver to strip those 4
> bytes. Unfortunately a change dating back to March 2017 re-shuffled some
> code and made the CRC stripping code effectively dead.
>
> This change re-orders that part a bit such that the datalen is
> immediately altered if needed.
>
> Fixes: 4902a92270fb ("drivers: net: xgene: Add workaround for errata 10GE_8/ENET_11")
> Signed-off-by: Stephane Graber <stgraber@ubuntu.com>
> Tested-by: Stephane Graber <stgraber@ubuntu.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> index ff2d099aab21..3892790f04e0 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> @@ -696,6 +696,12 @@ static int xgene_enet_rx_frame(struct xgene_enet_desc_ring *rx_ring,
> buf_pool->rx_skb[skb_index] = NULL;
>
> datalen = xgene_enet_get_data_len(le64_to_cpu(raw_desc->m1));
> +
> + /* strip off CRC as HW isn't doing this */
> + nv = GET_VAL(NV, le64_to_cpu(raw_desc->m0));
> + if (!nv)
> + datalen -= 4;
Alternatively we could call skb_trim() below to remove the FCS.
You call, but..
> skb_put(skb, datalen);
> prefetch(skb->data - NET_IP_ALIGN);
> skb->protocol = eth_type_trans(skb, ndev);
> @@ -717,10 +723,7 @@ static int xgene_enet_rx_frame(struct xgene_enet_desc_ring *rx_ring,
> }
> }
>
> - nv = GET_VAL(NV, le64_to_cpu(raw_desc->m0));
> if (!nv) {
> - /* strip off CRC as HW isn't doing this */
> - datalen -= 4;
> goto skip_jumbo;
> }
If you stick to moving the datalen adjustments this if will have a
single statement so according to the kernel code style it has to lose
the brackets.
next prev parent reply other threads:[~2022-03-18 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 14:42 [PATCH] drivers: net: xgene: Fix regression in CRC stripping Stéphane Graber
2022-03-18 21:12 ` Jakub Kicinski [this message]
2022-03-22 22:42 ` [PATCH v2] " Stéphane Graber
2022-03-23 17:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318141207.284972b7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=iyappan@os.amperecomputing.com \
--cc=keyur@os.amperecomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quan@os.amperecomputing.com \
--cc=stable@vger.kernel.org \
--cc=stgraber@ubuntu.com \
--cc=toan@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).