stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: "Christian Göttsche" <cgzones@googlemail.com>,
	"Paul Moore" <paul@paul-moore.com>,
	"Sasha Levin" <sashal@kernel.org>,
	stephen.smalley.work@gmail.com, eparis@parisplace.org,
	selinux@vger.kernel.org
Subject: [PATCH AUTOSEL 5.4 05/16] selinux: use correct type for context length
Date: Mon, 28 Mar 2022 07:23:34 -0400	[thread overview]
Message-ID: <20220328112345.1556601-5-sashal@kernel.org> (raw)
In-Reply-To: <20220328112345.1556601-1-sashal@kernel.org>

From: Christian Göttsche <cgzones@googlemail.com>

[ Upstream commit b97df7c098c531010e445da88d02b7bf7bf59ef6 ]

security_sid_to_context() expects a pointer to an u32 as the address
where to store the length of the computed context.

Reported by sparse:

    security/selinux/xfrm.c:359:39: warning: incorrect type in arg 4
                                    (different signedness)
    security/selinux/xfrm.c:359:39:    expected unsigned int
                                       [usertype] *scontext_len
    security/selinux/xfrm.c:359:39:    got int *

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
[PM: wrapped commit description]
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 security/selinux/xfrm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/selinux/xfrm.c b/security/selinux/xfrm.c
index 7314196185d1..00e95f8bd7c7 100644
--- a/security/selinux/xfrm.c
+++ b/security/selinux/xfrm.c
@@ -346,7 +346,7 @@ int selinux_xfrm_state_alloc_acquire(struct xfrm_state *x,
 	int rc;
 	struct xfrm_sec_ctx *ctx;
 	char *ctx_str = NULL;
-	int str_len;
+	u32 str_len;
 
 	if (!polsec)
 		return 0;
-- 
2.34.1


  parent reply	other threads:[~2022-03-28 11:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 11:23 [PATCH AUTOSEL 5.4 01/16] LSM: general protection fault in legacy_parse_param Sasha Levin
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 02/16] gcc-plugins/stackleak: Exactly match strings instead of prefixes Sasha Levin
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 03/16] pinctrl: npcm: Fix broken references to chip->parent_device Sasha Levin
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 04/16] block, bfq: don't move oom_bfqq Sasha Levin
2022-03-28 11:23 ` Sasha Levin [this message]
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 06/16] loop: use sysfs_emit() in the sysfs xxx show() Sasha Levin
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 07/16] Fix incorrect type in assignment of ipv6 port for audit Sasha Levin
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 08/16] irqchip/qcom-pdc: Fix broken locking Sasha Levin
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 09/16] irqchip/nvic: Release nvic_base upon failure Sasha Levin
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 10/16] bfq: fix use-after-free in bfq_dispatch_request Sasha Levin
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 11/16] ACPICA: Avoid walking the ACPI Namespace if it is not there Sasha Levin
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 12/16] lib/raid6/test/Makefile: Use $(pound) instead of \# for Make 4.3 Sasha Levin
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 13/16] Revert "Revert "block, bfq: honor already-setup queue merges"" Sasha Levin
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 14/16] ACPI/APEI: Limit printable size of BERT table data Sasha Levin
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 15/16] PM: core: keep irq flags in device_pm_check_callbacks() Sasha Levin
2022-03-28 11:23 ` [PATCH AUTOSEL 5.4 16/16] spi: tegra20: Use of_device_get_match_data() Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220328112345.1556601-5-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=cgzones@googlemail.com \
    --cc=eparis@parisplace.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=selinux@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=stephen.smalley.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).