From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B9E2C433FE for ; Wed, 4 May 2022 17:17:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237127AbiEDRVa (ORCPT ); Wed, 4 May 2022 13:21:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357855AbiEDRPY (ORCPT ); Wed, 4 May 2022 13:15:24 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38D3655366 for ; Wed, 4 May 2022 09:59:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 61D51B827A9 for ; Wed, 4 May 2022 16:59:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0254DC385AA; Wed, 4 May 2022 16:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651683541; bh=DsvDXQ6kJurnErLDL/h4yzU+dd34La7QD2HADaIGc/Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LX2rUqJjXjNGUN1l8abH0H1+XGN2f3YChOTtQ4esB182SxyxKYKPId4GGNOoNz8uh KH6fN/2YxeRSwiwKf02zG392IFIk68/ICTlpPtL62GDQ0hAmsx3TqxqPUiV6I5DuwK ew3S0+aFUBZoLRrHRAO5ixNYKsFOZRXm7B3iAQ80JtCfLdnPiub3s5kCcbPBII3Y4O 5RAALpJD+M/ItqMCZZ8C/YU8esUf0SdWAkEX2iHj6KZEnrhdoRqkoHtCNRneRQJKp7 A6nmG1nfsQvjt9iQPJynArXL3nVSnA6AFSWsuURDLU2H43SWqMjjK/xkShBBtLOudO dALFa0P8BSA8Q== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Greg Kroah-Hartman , Sasha Levin Cc: stable@vger.kernel.org, pali@kernel.org, =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH 5.17 03/19] PCI: aardvark: Check return value of generic_handle_domain_irq() when processing INTx IRQ Date: Wed, 4 May 2022 18:58:36 +0200 Message-Id: <20220504165852.30089-4-kabel@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220504165852.30089-1-kabel@kernel.org> References: <20220504165852.30089-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Pali Rohár commit 51f96e287c6f003d3bb29672811c757c5fbf0028 upstream. It is possible that we receive spurious INTx interrupt. Check for the return value of generic_handle_domain_irq() when processing INTx IRQ. Link: https://lore.kernel.org/r/20220110015018.26359-6-kabel@kernel.org Signed-off-by: Pali Rohár Signed-off-by: Marek Behún Signed-off-by: Lorenzo Pieralisi Signed-off-by: Marek Behún --- drivers/pci/controller/pci-aardvark.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index 73ffe9ae3bf6..3f7c38920713 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -1427,7 +1427,9 @@ static void advk_pcie_handle_int(struct advk_pcie *pcie) advk_writel(pcie, PCIE_ISR1_INTX_ASSERT(i), PCIE_ISR1_REG); - generic_handle_domain_irq(pcie->irq_domain, i); + if (generic_handle_domain_irq(pcie->irq_domain, i) == -EINVAL) + dev_err_ratelimited(&pcie->pdev->dev, "unexpected INT%c IRQ\n", + (char)i + 'A'); } } -- 2.35.1