From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>,
Johannes Berg <johannes@sipsolutions.net>,
Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] rfkill: uapi: fix RFKILL_IOCTL_MAX_SIZE ioctl request definition
Date: Sat, 7 May 2022 11:45:14 +0300 [thread overview]
Message-ID: <20220507084514.GA5026@altlinux.org> (raw)
In-Reply-To: <YnYaVeCJA1VQuYie@kroah.com>
On Sat, May 07, 2022 at 09:05:57AM +0200, Greg KH wrote:
> On Fri, May 06, 2022 at 05:24:54PM +0000, Gleb Fotengauer-Malinovskiy wrote:
> > Fixes: 54f586a91532 ("rfkill: make new event layout opt-in")
> > Cc: stable@vger.kernel.org # 5.11+
> > Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
> > ---
>
> No changelog text at all? I know I don't take patches like that, maybe
> other subsystem maintainers are more lax?
>
> Please provide a changelog...
The definition of RFKILL_IOCTL_MAX_SIZE introduced by commit 54f586a91532
is unusable since it is based on RFKILL_IOC_EXT_SIZE which has not been
defined. Fix that by replacing the undefined constant with the constant
which is intended to be used in this definition.
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
--
ldv
prev parent reply other threads:[~2022-05-07 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220506171534.99509-1-glebfm@altlinux.org>
2022-05-06 17:24 ` [PATCH v2] rfkill: uapi: fix RFKILL_IOCTL_MAX_SIZE ioctl request definition Gleb Fotengauer-Malinovskiy
2022-05-07 7:05 ` Greg KH
2022-05-07 8:45 ` Dmitry V. Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220507084514.GA5026@altlinux.org \
--to=ldv@altlinux.org \
--cc=glebfm@altlinux.org \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).