stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: "stephen@networkplumber.org" <stephen@networkplumber.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net-sysfs: allow changing sysfs carrier when interface is down
Date: Thu, 2 Jun 2022 09:57:56 -0700	[thread overview]
Message-ID: <20220602095756.764471e8@kernel.org> (raw)
In-Reply-To: <b4b1b8519ef9bfef0d09aeea7ab8f89e531130c8.camel@infinera.com>

On Thu, 2 Jun 2022 16:26:18 +0000 Joakim Tjernlund wrote:
> On Thu, 2022-06-02 at 08:56 -0700, Stephen Hemminger wrote:
> > > Sure, our HW has config/state changes that makes it impossible for net driver
> > > to touch and registers or TX pkgs(can result in System Error exception in worst case.

What is "our HW", what kernel driver does it use and why can't the
kernel driver take care of making sure the device is not accessed
when it'd crash the system?

> Maybe so but it seems to me that this limitation was put in place without much thought.

Don't make unnecessary disparaging statements about someone else's work.
Whoever that person was.

  reply	other threads:[~2022-06-02 16:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02  0:35 [PATCH] net-sysfs: allow changing sysfs carrier when interface is down Joakim Tjernlund
2022-06-02  1:01 ` Jakub Kicinski
2022-06-02  9:22   ` Joakim Tjernlund
2022-06-02 15:56     ` Stephen Hemminger
2022-06-02 16:26       ` Joakim Tjernlund
2022-06-02 16:57         ` Jakub Kicinski [this message]
2022-06-02 17:15           ` Joakim Tjernlund
2022-06-02 17:52             ` Jakub Kicinski
2022-06-02 18:01               ` Joakim Tjernlund
2022-06-05 18:50                 ` Andrew Lunn
2022-06-07 11:52                   ` Joakim Tjernlund
2022-06-02 18:14               ` Stephen Hemminger
2022-06-02 17:56             ` Stephen Hemminger
2022-06-02 18:09               ` Joakim Tjernlund
2022-06-02 18:38                 ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220602095756.764471e8@kernel.org \
    --to=kuba@kernel.org \
    --cc=Joakim.Tjernlund@infinera.com \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).