From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C88C8C433EF for ; Tue, 7 Jun 2022 18:23:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351424AbiFGSX1 (ORCPT ); Tue, 7 Jun 2022 14:23:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352417AbiFGSRI (ORCPT ); Tue, 7 Jun 2022 14:17:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22CFF248C9; Tue, 7 Jun 2022 10:51:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B24DF61797; Tue, 7 Jun 2022 17:51:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01635C3411C; Tue, 7 Jun 2022 17:51:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654624316; bh=i2gqG+rvriNRy8tZ4tU5UoL257WJO3AT0OxukhJJBOo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CcV+WVGw7eoflsK8QJSxNLGjpx7bk/n/YlpGXXAJxpdxbaTlbyWu0/vFEUEMTbdRd BAAeX6THOSxpSnA91G4qyxI7tzwHUM/s4WOR8g7HoymrMwmnMm8EJEhqKMZClpDkDb xe06AWFkUp76NTJ6xLSSr9vOAtuy/v6gthljhGGT231WTLXT8eZkkOmslRrpLXl8pi ZfbnArrK51PhCGMq9QhDvlILYlUhBxAFsbvbFlX1jClpXC+I8Ikl9w5JooRVrK0dl1 WEu3acCPBCwLCBHLz8Lw/QHLYTvajRDs3xZ3h8/Ak2cPglpYcJACDJAyqAo5yCeUGK PEHzoOkjCIEEA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Gong Yuanjun , Alex Deucher , Sasha Levin , evan.quan@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch, ray.huang@amd.com, lijo.lazar@amd.com, aaron.liu@amd.com, Xiaomeng.Hou@amd.com, sathishkumar.sundararaju@amd.com, Perry.Yuan@amd.com, yifan1.zhang@amd.com, mario.limonciello@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.18 48/68] drm/amd/pm: fix a potential gpu_metrics_table memory leak Date: Tue, 7 Jun 2022 13:48:14 -0400 Message-Id: <20220607174846.477972-48-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220607174846.477972-1-sashal@kernel.org> References: <20220607174846.477972-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Gong Yuanjun [ Upstream commit d2f4460a3d9502513419f06cc376c7ade49d5753 ] gpu_metrics_table is allocated in yellow_carp_init_smc_tables() but not freed in yellow_carp_fini_smc_tables(). Signed-off-by: Gong Yuanjun Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c index e2d099409123..c66c39ccf19c 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c @@ -190,6 +190,9 @@ static int yellow_carp_fini_smc_tables(struct smu_context *smu) kfree(smu_table->watermarks_table); smu_table->watermarks_table = NULL; + kfree(smu_table->gpu_metrics_table); + smu_table->gpu_metrics_table = NULL; + return 0; } -- 2.35.1