From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77B28C43334 for ; Tue, 7 Jun 2022 18:24:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350651AbiFGSX6 (ORCPT ); Tue, 7 Jun 2022 14:23:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352069AbiFGSUt (ORCPT ); Tue, 7 Jun 2022 14:20:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F7D130541; Tue, 7 Jun 2022 10:53:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B4F2BB8236D; Tue, 7 Jun 2022 17:53:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB7D5C34115; Tue, 7 Jun 2022 17:53:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654624405; bh=C3p8V+CShGR7nozEVmR7aMQKSLK+SVYLvPNgHctlLf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kol9521fs7CqhKFDDdll/nC+p02+bkXFS15aavvICnohaQrV6tFixRJ0Idw9GOANc C/W1NJZvdimJL3Xq2DlR+aV2pg2BaqEa90/9jqDHZwlBkIr0JlPDzxsFljVyjYhy/5 Ky/niUUAbVb7tmrPcdGpI+2Io19wPbu3wpqxQHlHhQqy0IYGMp/Z3GiSipypfvykBA 0vkuANyr4RZ/2m0mKcejc8OxbMq20zJ3h45UO4K+nSv2+khfyIrq35Fdz4jG6VgVS9 1LrH8lCFqDZvS8yVjiHi3aYAjldyjjItKlxdE0nRMbHXfGF/eWe5wP0Wi5/xwCHXSQ 43AD/R5TJpKmg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Huang Guobin , Jiri Slaby , Greg Kroah-Hartman , Sasha Levin , linux-serial@vger.kernel.org Subject: [PATCH AUTOSEL 5.17 08/60] tty: Fix a possible resource leak in icom_probe Date: Tue, 7 Jun 2022 13:52:05 -0400 Message-Id: <20220607175259.478835-8-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220607175259.478835-1-sashal@kernel.org> References: <20220607175259.478835-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Huang Guobin [ Upstream commit ee157a79e7c82b01ae4c25de0ac75899801f322c ] When pci_read_config_dword failed, call pci_release_regions() and pci_disable_device() to recycle the resource previously allocated. Reviewed-by: Jiri Slaby Signed-off-by: Huang Guobin Link: https://lore.kernel.org/r/20220331091005.3290753-1-huangguobin4@huawei.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/icom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/icom.c b/drivers/tty/serial/icom.c index 03a2fe9f4c9a..02b375ba2f07 100644 --- a/drivers/tty/serial/icom.c +++ b/drivers/tty/serial/icom.c @@ -1501,7 +1501,7 @@ static int icom_probe(struct pci_dev *dev, retval = pci_read_config_dword(dev, PCI_COMMAND, &command_reg); if (retval) { dev_err(&dev->dev, "PCI Config read FAILED\n"); - return retval; + goto probe_exit0; } pci_write_config_dword(dev, PCI_COMMAND, -- 2.35.1