From: Jakub Kicinski <kuba@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
x86@kernel.org, Nick Desaulniers <ndesaulniers@google.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
stable@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] x86/speculation: Use DECLARE_PER_CPU for x86_spec_ctrl_current
Date: Thu, 14 Jul 2022 14:30:05 -0700 [thread overview]
Message-ID: <20220714143005.73c71cf8@kernel.org> (raw)
In-Reply-To: <20220713152436.2294819-1-nathan@kernel.org>
On Wed, 13 Jul 2022 08:24:37 -0700 Nathan Chancellor wrote:
> Clang warns:
>
> arch/x86/kernel/cpu/bugs.c:58:21: error: section attribute is specified on redeclared variable [-Werror,-Wsection]
> DEFINE_PER_CPU(u64, x86_spec_ctrl_current);
> ^
> arch/x86/include/asm/nospec-branch.h:283:12: note: previous declaration is here
> extern u64 x86_spec_ctrl_current;
> ^
> 1 error generated.
>
> The declaration should be using DECLARE_PER_CPU instead so all
> attributes stay in sync.
>
> Cc: stable@vger.kernel.org
> Fixes: fc02735b14ff ("KVM: VMX: Prevent guest RSB poisoning attacks with eIBRS")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Hi, sorry to bother, any idea on the ETA for this fix getting into
Linus's tree? I'm trying to figure out if we should wait with
forwarding the networking trees or this will take a while.
next prev parent reply other threads:[~2022-07-14 21:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 15:24 [PATCH v2] x86/speculation: Use DECLARE_PER_CPU for x86_spec_ctrl_current Nathan Chancellor
2022-07-13 15:36 ` Nick Desaulniers
2022-07-13 16:22 ` Peter Zijlstra
2022-07-13 16:27 ` Nathan Chancellor
2022-07-14 21:30 ` Jakub Kicinski [this message]
2022-07-14 21:51 ` Linus Torvalds
2022-07-14 21:56 ` Linus Torvalds
2022-07-14 22:11 ` Peter Zijlstra
2022-07-14 21:56 ` Jakub Kicinski
2022-07-14 22:14 ` Linus Torvalds
2022-07-14 22:18 ` Jakub Kicinski
2022-07-15 16:00 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714143005.73c71cf8@kernel.org \
--to=kuba@kernel.org \
--cc=bp@suse.de \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).