From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E410C54EE9 for ; Tue, 30 Aug 2022 17:54:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbiH3RyG (ORCPT ); Tue, 30 Aug 2022 13:54:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232201AbiH3Rxm (ORCPT ); Tue, 30 Aug 2022 13:53:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B93AD40E1C; Tue, 30 Aug 2022 10:51:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D2B93617C6; Tue, 30 Aug 2022 17:25:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 987D7C433D6; Tue, 30 Aug 2022 17:25:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661880344; bh=a+jGllAZSwuc0+0coQ7c2Fzy/wkOd3gtKfjUe6cEIzY=; h=From:To:Cc:Subject:Date:From; b=d960gE/o0rp1cJc3eIVane+De61+Rx7FaYgJ+WQWQtcJJl9KDL90PvlLU1P2pM+LF /gID/GywXL9aZ8kCxr70uzT22feZ02WUlvHNz1G0gYO/Xk7xKEaAEhJ/nT4dZ4W2Qz 2kJIi6E/EBnSFewpF7WADMZTRuXDF0qQRalyypIGeFebRgELsaoBHg52BurJzPiyMY ExySvM/o6/apYFcmX367vqZC6VV8hW+W8sbc9mw06tTIDAXv+PFRbnhGD1Pt+s+OYC NnlQAjYaVqNBv0MZTvakwfPPp+zOARXvw7Ko4IPXs5fxW+2B9bEx46E9xbsD/3ygLd qwbbBTzYSl2Sw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andy Shevchenko , Jean Delvare , Sasha Levin , jdelvare@suse.com Subject: [PATCH AUTOSEL 4.19 01/10] firmware: dmi: Use the proper accessor for the version field Date: Tue, 30 Aug 2022 13:25:32 -0400 Message-Id: <20220830172541.581820-1-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Andy Shevchenko [ Upstream commit d2139dfca361a1f5bfc4d4a23455b1a409a69cd4 ] The byte at offset 6 represents length. Don't take it and drop it immediately by using proper accessor, i.e. get_unaligned_be24(). [JD: Change the subject to something less frightening] Signed-off-by: Andy Shevchenko Signed-off-by: Jean Delvare Signed-off-by: Sasha Levin --- drivers/firmware/dmi_scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c index 0dc0c78f1fdb2..c47680adbf367 100644 --- a/drivers/firmware/dmi_scan.c +++ b/drivers/firmware/dmi_scan.c @@ -595,7 +595,7 @@ static int __init dmi_smbios3_present(const u8 *buf) { if (memcmp(buf, "_SM3_", 5) == 0 && buf[6] < 32 && dmi_checksum(buf, buf[6])) { - dmi_ver = get_unaligned_be32(buf + 6) & 0xFFFFFF; + dmi_ver = get_unaligned_be24(buf + 7); dmi_num = 0; /* No longer specified */ dmi_len = get_unaligned_le32(buf + 12); dmi_base = get_unaligned_le64(buf + 16); -- 2.35.1