From: Tom Saeger <tom.saeger@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, "H.J. Lu" <hjl.tools@gmail.com>,
Kees Cook <keescook@chromium.org>,
Vegard Nossum <vegard.nossum@oracle.com>,
konstantin@linuxfoundation.org, robh@kernel.org
Subject: Re: [PATCH 5.4 v3 1/6] x86, vmlinux.lds: Add RUNTIME_DISCARD_EXIT to generic DISCARDS
Date: Wed, 15 Mar 2023 09:30:18 -0500 [thread overview]
Message-ID: <20230315143018.fnhhvhm3gvyfozcg@oracle.com> (raw)
In-Reply-To: <ZBGER4HqDnvotSNg@kroah.com>
On Wed, Mar 15, 2023 at 09:39:35AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Mar 01, 2023 at 07:06:59PM -0700, Tom Saeger wrote:
> > From: "H.J. Lu" <hjl.tools@gmail.com>
> >
> > commit 84d5f77fc2ee4e010c2c037750e32f06e55224b0 upstream.
> >
> > In the x86 kernel, .exit.text and .exit.data sections are discarded at
> > runtime, not by the linker. Add RUNTIME_DISCARD_EXIT to generic DISCARDS
> > and define it in the x86 kernel linker script to keep them.
> >
> > The sections are added before the DISCARD directive so document here
> > only the situation explicitly as this change doesn't have any effect on
> > the generated kernel. Also, other architectures like ARM64 will use it
> > too so generalize the approach with the RUNTIME_DISCARD_EXIT define.
> >
> > [ bp: Massage and extend commit message. ]
> >
> > Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
> > Signed-off-by: Borislav Petkov <bp@suse.de>
> > Reviewed-by: Kees Cook <keescook@chromium.org>
> > Link: https://lkml.kernel.org/r/20200326193021.255002-1-hjl.tools@gmail.com
> > Signed-off-by: Tom Saeger <tom.saeger@oracle.com>
>
> The encoding of this email was very odd, with dos line-ends? Something
> was odd on your side, all the others were fine. I've fixed it up...
>
> strange,
>
> greg k-h
Thanks for pointing this out, and for fixing-up patch.
My first thought was to blame `b4 prep`.
Vegard helped me track this down:
Rob already reported here: https://lore.kernel.org/all/CAL_JsqJHGUMsLUpH=s8Xa46NU9dbBuvPMCPJyRwQdvFr3WK9tw@mail.gmail.com/
Konstantin already fixed: https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=ebd05d6210e3421af2918dc178985789cc5fc390
Verified this locally.
# b4 version == 0.12.0
❯ file tmp-20230301_1858/*
tmp-20230301_1858/0000-fix-build-id-on-arm64-if-config_modversions-y.eml: news or mail, ASCII text, with CRLF line terminators
tmp-20230301_1858/0001-x86-vmlinux-lds-add-runtime_discard_exit-to-generic-discards.eml: unified diff output, ASCII text, with CRLF line terminators
tmp-20230301_1858/0002-arch-fix-broken-buildid-for-arm64-and-riscv.eml: unified diff output, ASCII text
tmp-20230301_1858/0003-powerpc-vmlinux-lds-define-runtime_discard_exit.eml: unified diff output, ASCII text
tmp-20230301_1858/0004-powerpc-vmlinux-lds-don-t-discard-rela-for-relocatable-builds.eml: unified diff output, ASCII text
tmp-20230301_1858/0005-s390-define-runtime_discard_exit-to-fix-link-error-with-gnu-ld-2-36.eml: unified diff output, ASCII text
tmp-20230301_1858/0006-sh-define-runtime_discard_exit.eml: unified diff output, ASCII text
# b4 version >= 0.12.2
❯ file tmp-20230315_0806/*
tmp-20230315_0806/0000-fix-build-id-on-arm64-if-config_modversions-y.eml: news or mail, ASCII text
tmp-20230315_0806/0001-x86-vmlinux-lds-add-runtime_discard_exit-to-generic-discards.eml: unified diff output, ASCII text
tmp-20230315_0806/0002-arch-fix-broken-buildid-for-arm64-and-riscv.eml: unified diff output, ASCII text
tmp-20230315_0806/0003-powerpc-vmlinux-lds-define-runtime_discard_exit.eml: unified diff output, ASCII text
tmp-20230315_0806/0004-powerpc-vmlinux-lds-don-t-discard-rela-for-relocatable-builds.eml: unified diff output, ASCII text
tmp-20230315_0806/0005-s390-define-runtime_discard_exit-to-fix-link-error-with-gnu-ld-2-36.eml: unified diff output, ASCII text
tmp-20230315_0806/0006-sh-define-runtime_discard_exit.eml: unified diff output, ASCII text
Regards,
--Tom
next prev parent reply other threads:[~2023-03-15 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 2:06 [PATCH 5.4 v3 0/6] Fix Build ID on arm64 if CONFIG_MODVERSIONS=y Tom Saeger
2023-03-02 2:06 ` [PATCH 5.4 v3 1/6] x86, vmlinux.lds: Add RUNTIME_DISCARD_EXIT to generic DISCARDS Tom Saeger
2023-03-15 8:39 ` Greg Kroah-Hartman
2023-03-15 14:30 ` Tom Saeger [this message]
2023-03-02 2:07 ` [PATCH 5.4 v3 2/6] arch: fix broken BuildID for arm64 and riscv Tom Saeger
2023-03-02 2:07 ` [PATCH 5.4 v3 3/6] powerpc/vmlinux.lds: Define RUNTIME_DISCARD_EXIT Tom Saeger
2023-03-02 2:07 ` [PATCH 5.4 v3 4/6] powerpc/vmlinux.lds: Don't discard .rela* for relocatable builds Tom Saeger
2023-03-02 2:07 ` [PATCH 5.4 v3 5/6] s390: define RUNTIME_DISCARD_EXIT to fix link error with GNU ld < 2.36 Tom Saeger
2023-03-02 2:07 ` [PATCH 5.4 v3 6/6] sh: define RUNTIME_DISCARD_EXIT Tom Saeger
2023-03-15 8:40 ` [PATCH 5.4 v3 0/6] Fix Build ID on arm64 if CONFIG_MODVERSIONS=y Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315143018.fnhhvhm3gvyfozcg@oracle.com \
--to=tom.saeger@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=hjl.tools@gmail.com \
--cc=keescook@chromium.org \
--cc=konstantin@linuxfoundation.org \
--cc=robh@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).