From: Greg KH <gregkh@linuxfoundation.org>
To: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Cc: stable@vger.kernel.org, sashal@kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH for 4.14, 4.19] usb: host: ohci-pxa27x: Fix and & vs | typo
Date: Mon, 3 Apr 2023 15:10:27 +0200 [thread overview]
Message-ID: <2023040321-plausibly-violet-0aa0@gregkh> (raw)
In-Reply-To: <20230330051649.431149-1-nobuhiro1.iwamatsu@toshiba.co.jp>
On Thu, Mar 30, 2023 at 02:16:49PM +0900, Nobuhiro Iwamatsu wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
>
> commit 0709831a50d31b3caf2237e8d7fe89e15b0d919d upstream.
>
> The code is supposed to clear the RH_A_NPS and RH_A_PSM bits, but it's
> a no-op because of the & vs | typo. This bug predates git and it was
> only discovered using static analysis so it must not affect too many
> people in real life.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> Link: https://lore.kernel.org/r/20190817065520.GA29951@mwanda
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu@toshiba.co.jp>
> ---
> drivers/usb/host/ohci-pxa27x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-04-03 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 5:16 [PATCH for 4.14, 4.19] usb: host: ohci-pxa27x: Fix and & vs | typo Nobuhiro Iwamatsu
2023-04-03 13:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023040321-plausibly-violet-0aa0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).