From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Liu Shixin <liushixin2@huawei.com>,
stable@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Sasha Levin <sashal@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH stable-5.10] mm/memory-failure: fix an incorrect use of tail pages
Date: Sat, 30 Mar 2024 10:12:31 +0100 [thread overview]
Message-ID: <2024033024-unusable-secret-6872@gregkh> (raw)
In-Reply-To: <ZgD2EvkzS1Uz5wy6@casper.infradead.org>
On Mon, Mar 25, 2024 at 03:57:06AM +0000, Matthew Wilcox wrote:
> On Mon, Mar 25, 2024 at 11:36:49AM +0800, Liu Shixin wrote:
> > Hi,
> >
> > After backport commit c79c5a0a00a9 ("mm/memory-failure: check the mapcount of the precise page"),
> >
> > I got an error message as written on the patch. The problem can be fixed by the patch or just revert.
> >
> > Now I prefer to revert because I think it is related to folio and no impact in stable, or maybe I'm wrong.
>
> I checked out what is going wrong here, and Liu Shixin is correct.
>
> Commit c79c5a0a00a9 was incorrectly backported to v5.10 and
> commit 70168fdc743b changees the page passed to try_to_unmap().
> It now passes the tail page, and should always have passed hpage.
> Please apply the patch below to v5.10 (and any other trees that
> c79c5a0a00a9 got backported to).
All now queued up,t hanks.
greg k-h
prev parent reply other threads:[~2024-03-30 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 12:48 [PATCH stable-5.10] mm/memory-failure: fix an incorrect use of tail pages Liu Shixin
2024-03-11 1:51 ` Liu Shixin
2024-03-25 3:36 ` Liu Shixin
2024-03-25 3:57 ` Matthew Wilcox
2024-03-30 9:12 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024033024-unusable-secret-6872@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).