stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Naveen Krishna Chatradhi <nchatrad@amd.com>, linux-hwmon@vger.kernel.org
Cc: naveenkrishna.ch@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH] hwmon: amd_energy: modify the visibility of the counters
Date: Thu, 12 Nov 2020 09:24:22 -0800	[thread overview]
Message-ID: <238e3cf7-582f-a265-5300-9b44948107b0@roeck-us.net> (raw)
In-Reply-To: <20201112172159.8781-1-nchatrad@amd.com>

On 11/12/20 9:21 AM, Naveen Krishna Chatradhi wrote:
> This patch limits the visibility to owner and groups only for the
> energy counters exposed through the hwmon based amd_energy driver.
> 
> Cc: stable@vger.kernel.org
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>

This is very unusual, and may mess up the "sensors" command.
What problem is this trying to solve ?

Guenter

> ---
>  drivers/hwmon/amd_energy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/amd_energy.c b/drivers/hwmon/amd_energy.c
> index d06597303d5a..3197cda7bcd9 100644
> --- a/drivers/hwmon/amd_energy.c
> +++ b/drivers/hwmon/amd_energy.c
> @@ -171,7 +171,7 @@ static umode_t amd_energy_is_visible(const void *_data,
>  				     enum hwmon_sensor_types type,
>  				     u32 attr, int channel)
>  {
> -	return 0444;
> +	return 0440;
>  }
>  
>  static int energy_accumulator(void *p)
> 


  reply	other threads:[~2020-11-12 17:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12 17:21 [PATCH] hwmon: amd_energy: modify the visibility of the counters Naveen Krishna Chatradhi
2020-11-12 17:24 ` Guenter Roeck [this message]
2020-11-13 13:58   ` Salvatore Bonaccorso
2020-11-13 14:47     ` Guenter Roeck
2020-11-22  6:56     ` Chatradhi, Naveen Krishna
2020-11-22 13:30       ` Guenter Roeck
2020-11-22 16:42         ` Chatradhi, Naveen Krishna
2020-11-22 18:09           ` Guenter Roeck
  -- strict thread matches above, loose matches on Subject: below --
2020-11-09  9:07 Naveen Krishna Chatradhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=238e3cf7-582f-a265-5300-9b44948107b0@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=naveenkrishna.ch@gmail.com \
    --cc=nchatrad@amd.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).