From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: "Ewan D. Milne" <emilne@redhat.com>, linux-scsi@vger.kernel.org
Cc: stable@vger.kernel.org, njavali@marvell.com, aeasi@marvell.com
Subject: Re: [PATCH] scsi: qla2xxx: fix mailbox direction flags in qla2xxx_get_adapter_id()
Date: Mon, 8 Nov 2021 17:11:57 -0600 [thread overview]
Message-ID: <23d594f0-7bcd-5002-175c-d476dc6c3ae0@oracle.com> (raw)
In-Reply-To: <20211108183012.13895-1-emilne@redhat.com>
On 11/8/21 12:30, Ewan D. Milne wrote:
> The SCM changes set the flags in mcp->out_mb instead of mcp->in_mb
> so the data was not actually being read into the mcp->mb[] array from
> the adapter.
>
> Fixes: 9f2475fe7406 ("scsi: qla2xxx: SAN congestion management implementation")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ewan D. Milne <emilne@redhat.com>
> ---
> drivers/scsi/qla2xxx/qla_mbx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
> index 7811c4952035..a6debeea3079 100644
> --- a/drivers/scsi/qla2xxx/qla_mbx.c
> +++ b/drivers/scsi/qla2xxx/qla_mbx.c
> @@ -1695,10 +1695,8 @@ qla2x00_get_adapter_id(scsi_qla_host_t *vha, uint16_t *id, uint8_t *al_pa,
> mcp->in_mb |= MBX_13|MBX_12|MBX_11|MBX_10;
> if (IS_FWI2_CAPABLE(vha->hw))
> mcp->in_mb |= MBX_19|MBX_18|MBX_17|MBX_16;
> - if (IS_QLA27XX(vha->hw) || IS_QLA28XX(vha->hw)) {
> - mcp->in_mb |= MBX_15;
> - mcp->out_mb |= MBX_7|MBX_21|MBX_22|MBX_23;
> - }
> + if (IS_QLA27XX(vha->hw) || IS_QLA28XX(vha->hw))
> + mcp->in_mb |= MBX_15|MBX_21|MBX_22|MBX_23;
>
> mcp->tov = MBX_TOV_SECONDS;
> mcp->flags = 0;
>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
next prev parent reply other threads:[~2021-11-08 23:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 18:30 [PATCH] scsi: qla2xxx: fix mailbox direction flags in qla2xxx_get_adapter_id() Ewan D. Milne
2021-11-08 23:11 ` Himanshu Madhani [this message]
2021-11-09 0:49 ` [EXT] " Arun Easi
2021-11-09 4:16 ` Martin K. Petersen
2021-11-19 4:16 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23d594f0-7bcd-5002-175c-d476dc6c3ae0@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=aeasi@marvell.com \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).