Stable Archive on
 help / color / Atom feed
From: Suzuki K Poulose <>
To: Greg KH <>
Subject: Re: [PATCH] arm64: cpufeature: Fix truncating a feature value
Date: Thu, 10 Oct 2019 13:46:21 +0100
Message-ID: <> (raw)
In-Reply-To: <>

On 10/10/2019 13:29, Greg KH wrote:
> On Thu, Oct 10, 2019 at 12:12:01PM +0100, Suzuki K Poulose wrote:
>> All,
>> On 10/10/2019 12:08, Suzuki K Poulose wrote:
>>> A signed feature value is truncated to turn to an unsigned value
>>> causing bad state in the system wide infrastructure. This affects
>>> the discovery of FP/ASIMD support on arm64. Fix this by making sure
>>> we cast it properly.
>>> Fixes: 4f0a606bce5ec ("arm64: cpufeature: Track unsigned fields")
>>> Cc: # v4.4
>> Please note that this patch is only applicable for stable 4.4 tree.
>> I should have removed the Fixes tag.
> Why is it only for 4.4?  That needs to be documented really really

This was fixed later in v4.6 onwards with commit 28c5dcb22f90113dea
("arm64: Rename cpuid_feature field extract routines") rather inadvertently.

> really well in the changelog as to why this is a one-off patch, and why
> we can't just take the relevant patches that are in Linus's tree
> instead.
> Please fix up and resend.

I can resend the patch with the above information included if you like.


  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 11:08 Suzuki K Poulose
2019-10-10 11:12 ` Suzuki K Poulose
2019-10-10 12:29   ` Greg KH
2019-10-10 12:46     ` Suzuki K Poulose [this message]
2019-10-10 13:16       ` Greg KH
2019-10-10 13:19     ` Suzuki K Poulose
2019-10-11  4:55       ` Greg KH
2019-10-11 10:31         ` Suzuki K Poulose
2019-10-11 12:13           ` Greg KH

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Stable Archive on

Archives are clonable:
	git clone --mirror stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ \
	public-inbox-index stable

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone