From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F988C2D0CD for ; Tue, 17 Dec 2019 12:15:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 469BB2176D for ; Tue, 17 Dec 2019 12:15:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726747AbfLQMPR (ORCPT ); Tue, 17 Dec 2019 07:15:17 -0500 Received: from mx3.molgen.mpg.de ([141.14.17.11]:37105 "EHLO mx1.molgen.mpg.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726690AbfLQMPR (ORCPT ); Tue, 17 Dec 2019 07:15:17 -0500 Received: from [192.168.0.5] (ip5f5bf3f4.dynamic.kabel-deutschland.de [95.91.243.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id D2D6B206441CD; Tue, 17 Dec 2019 13:15:14 +0100 (CET) Subject: Re: [PATCH] tpm: Don't make log failures fatal To: Matthew Garrett Cc: linux-integrity@vger.kernel.org, Jarkko Sakkinen , Matthew Garrett , stable@vger.kernel.org References: <20191213225748.11256-1-matthewgarrett@google.com> From: Paul Menzel Message-ID: <3a472005-83a7-9787-0bfc-35673702be09@molgen.mpg.de> Date: Tue, 17 Dec 2019 13:15:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20191213225748.11256-1-matthewgarrett@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Dear Matthew, Am 13.12.19 um 23:57 schrieb Matthew Garrett: > If a TPM is in disabled state, it's reasonable for it to have an empty > log. Bailing out of probe in this case means that the PPI interface > isn't available, so there's no way to then enable the TPM from the OS. > In general it seems reasonable to ignore log errors - they shouldn't > itnerfere with any other TPM functionality. interfere Can this be tested with QEMU somehow? > Signed-off-by: Matthew Garrett > Cc: stable@vger.kernel.org > --- > drivers/char/tpm/tpm-chip.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c > index 3d6d394a8661..58073836b555 100644 > --- a/drivers/char/tpm/tpm-chip.c > +++ b/drivers/char/tpm/tpm-chip.c > @@ -596,9 +596,7 @@ int tpm_chip_register(struct tpm_chip *chip) > > tpm_sysfs_add_device(chip); > > - rc = tpm_bios_log_setup(chip); > - if (rc != 0 && rc != -ENODEV) > - return rc; > + tpm_bios_log_setup(chip); > > tpm_add_ppi(chip); Acked-by: Paul Menzel Kind regards, Paul