From: Tejas Joglekar <Tejas.Joglekar@synopsys.com>
To: Felipe Balbi <balbi@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: Tejas Joglekar <Tejas.Joglekar@synopsys.com>,
John Youn <John.Youn@synopsys.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"greg@kroah.com" <greg@kroah.com>
Subject: Re: [PATCH] usb: dwc3: gadget: Fix logical condition
Date: Mon, 2 Dec 2019 11:30:10 +0000 [thread overview]
Message-ID: <3c556728-2934-a6f1-0093-4eec56fef86f@synopsys.com> (raw)
In-Reply-To: <9dcb74d7-17ed-c81e-c723-3f4848532b8b@synopsys.com>
Hello,
Gentle reminder...
On 11/22/2019 9:30 AM, Tejas Joglekar wrote:
> Hello Balbi,
> This is a critical patch fix for dwc3, can you please review ?
>
> On 11/13/2019 11:45 AM, Tejas Joglekar wrote:
>> This patch corrects the condition to kick the transfer without
>> giving back the requests when either request has remaining data
>> or when there are pending SGs. The && check was introduced during
>> spliting up the dwc3_gadget_ep_cleanup_completed_requests() function.
>>
>> Fixes: f38e35dd84e2 ("usb: dwc3: gadget: split dwc3_gadget_ep_cleanup_completed_requests()")
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Tejas Joglekar <joglekar@synopsys.com>
>> ---
>> drivers/usb/dwc3/gadget.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
>> index 86dc1db788a9..e07159e06f9a 100644
>> --- a/drivers/usb/dwc3/gadget.c
>> +++ b/drivers/usb/dwc3/gadget.c
>> @@ -2485,7 +2485,7 @@ static int dwc3_gadget_ep_cleanup_completed_request(struct dwc3_ep *dep,
>>
>> req->request.actual = req->request.length - req->remaining;
>>
>> - if (!dwc3_gadget_ep_request_completed(req) &&
>> + if (!dwc3_gadget_ep_request_completed(req) ||
>> req->num_pending_sgs) {
>> __dwc3_gadget_kick_transfer(dep);
>> goto out;
> Thanks & Regards,
>
> Tejas Joglekar
>
Thanks,
Tejas Joglekar
next prev parent reply other threads:[~2019-12-02 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 6:15 [PATCH] usb: dwc3: gadget: Fix logical condition Tejas Joglekar
2019-11-22 4:00 ` Tejas Joglekar
2019-12-02 11:30 ` Tejas Joglekar [this message]
2019-12-03 13:58 ` Felipe Balbi
2020-01-31 3:25 ` Jack Pham
2020-01-31 8:07 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c556728-2934-a6f1-0093-4eec56fef86f@synopsys.com \
--to=tejas.joglekar@synopsys.com \
--cc=John.Youn@synopsys.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).