From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Kalle Valo <kvalo@codeaurora.org>,
Loic Poulain <loic.poulain@linaro.org>
Cc: linux-wireless@vger.kernel.org, stable@vger.kernel.org,
Benjamin Li <benl@squareup.com>
Subject: Re: [PATCH] Revert "wcn36xx: Enable firmware link monitoring"
Date: Wed, 1 Sep 2021 00:51:25 +0100 [thread overview]
Message-ID: <40edf308-d12c-2116-0e5f-22cab413ea71@linaro.org> (raw)
In-Reply-To: <878s0i3yfq.fsf@codeaurora.org>
On 31/08/2021 07:44, Kalle Valo wrote:
> Loic Poulain <loic.poulain@linaro.org> writes:
>
>> This reverts commit wcn->hw, CONNECTION_MONITOR.
>>
>> The firmware keep-alive does not cause any event in case of error
>> such as non acked. It's just a basic keep alive to prevent the AP
>> to kick-off the station due to inactivity. So let mac80211 submit
>> its own monitoring packet (probe/null) and disconnect on timeout.
>>
>> Note: We want to keep firmware keep alive to prevent kick-off
>> when host is in suspend-to-mem (no mac80211 monitor packet).
>> Ideally fw keep alive should be enabled in suspend path and disabled
>> in resume path to prevent having both firmware and mac80211 submitting
>> periodic null packets.
>>
>> This fixes non detected AP leaving issues in active mode (nothing
>> monitors beacon or connection).
>>
>> Cc: stable@vger.kernel.org
>> Fixes: 8def9ec46a5f ("wcn36xx: Enable firmware link monitoring")
>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
>
> I'll queue this to v5.15.
>
Might want to hold off on that.
Its been reported by testing that wcn36xx_smd_delete_sta_context_ind()
actually _is_ firing.
But if you look at wcn36xx_smd_delete_sta_context_ind() it doesn't seem
to do ieee80211_connection_loss() like it presumably should.
I think the right fix here might be to call ieee80211_connection_loss()
in wcn36xx_smd_delete_sta_context_ind() if (wcn->hw & CONNECTION_MONITOR)
---
bod
next prev parent reply other threads:[~2021-08-31 23:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 17:09 [PATCH] Revert "wcn36xx: Enable firmware link monitoring" Loic Poulain
2021-08-31 1:15 ` Bryan O'Donoghue
[not found] ` <CAMZdPi8KE_MDBMiXT60O92FMpQtim1FhhQ548=Sw5pXWAP+GxQ@mail.gmail.com>
2021-08-31 6:46 ` Kalle Valo
2021-08-31 6:44 ` Kalle Valo
2021-08-31 23:51 ` Bryan O'Donoghue [this message]
2021-08-31 23:54 ` Bryan O'Donoghue
2021-09-01 6:14 ` Kalle Valo
2021-09-08 14:53 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40edf308-d12c-2116-0e5f-22cab413ea71@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=benl@squareup.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).