From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EBEFC432C0 for ; Fri, 29 Nov 2019 16:14:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C907215A5 for ; Fri, 29 Nov 2019 16:14:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="MIp0XX8k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbfK2QOV (ORCPT ); Fri, 29 Nov 2019 11:14:21 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:57527 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726909AbfK2QOU (ORCPT ); Fri, 29 Nov 2019 11:14:20 -0500 Received: from localhost (mailhub1-ext [192.168.12.233]) by localhost (Postfix) with ESMTP id 47Pfhn6hbbz9vBLm; Fri, 29 Nov 2019 17:14:17 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=MIp0XX8k; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id czFo_DUix5Vc; Fri, 29 Nov 2019 17:14:17 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 47Pfhn4lwGz9vBLl; Fri, 29 Nov 2019 17:14:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1575044057; bh=FovemUvA6qctABDabS0NtDnUTnpAPHjSV1V8/RSSR9g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=MIp0XX8k/I4wsfEgOYSzCsDkEXhTrmYqxehmxuBCm6XkDFcJq3T0hGxEYQ1Kz6NIG M7TpVa13ygd3AwlIJXHrwq1iQnMaePGf8TUnA+J1BqgPr3u+6+v9CF3rnVnRUCz+98 lseISBglyZJmBfRPyJbcLqVhWJ//g3rACrqlq9/Y= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 42FDF8B8DE; Fri, 29 Nov 2019 17:14:19 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 0j_ez_gOcD8Z; Fri, 29 Nov 2019 17:14:19 +0100 (CET) Received: from [172.25.230.103] (po15451.idsi0.si.c-s.fr [172.25.230.103]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 215048B8DC; Fri, 29 Nov 2019 17:14:19 +0100 (CET) Subject: Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw) To: Jens Axboe , "linuxppc-dev@lists.ozlabs.org" , Pavel Begunkov Cc: stable@vger.kernel.org, LKML References: <71cf82d5-5986-43b7-cf1c-acba429a89d6@c-s.fr> <3a95d445-1f5c-7750-f0de-ddc427800b3b@kernel.dk> From: Christophe Leroy Message-ID: <4ef71e74-848f-59d4-6b0b-d3a3c52095a0@c-s.fr> Date: Fri, 29 Nov 2019 17:14:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <3a95d445-1f5c-7750-f0de-ddc427800b3b@kernel.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Le 29/11/2019 à 17:04, Jens Axboe a écrit : > On 11/29/19 6:53 AM, Christophe Leroy wrote: >>     CC      fs/io_uring.o >> fs/io_uring.c: In function ‘loop_rw_iter’: >> fs/io_uring.c:1628:21: error: implicit declaration of function ‘kmap’ >> [-Werror=implicit-function-declaration] >>       iovec.iov_base = kmap(iter->bvec->bv_page) >>                        ^ >> fs/io_uring.c:1628:19: warning: assignment makes pointer from integer >> without a cast [-Wint-conversion] >>       iovec.iov_base = kmap(iter->bvec->bv_page) >>                      ^ >> fs/io_uring.c:1643:4: error: implicit declaration of function ‘kunmap’ >> [-Werror=implicit-function-declaration] >>       kunmap(iter->bvec->bv_page); >>       ^ >> >> >> Reverting commit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter >> fixed rw") clears the failure. >> >> Most likely an #include is missing. > > Huh weird how the build bots didn't catch that. Does the below work? Yes it works, thanks. Christophe