On 02/12/2019 12:30, Jani Nikula wrote: > On Mon, 25 Nov 2019, Chris Wilson wrote: >> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so >> update the user instructions accordingly. >> >> Signed-off-by: Chris Wilson >> Cc: Martin Peres >> Cc: Joonas Lahtinen >> Cc: Rodrigo Vivi >> Cc: Jani Nikula >> Cc: stable@vger.kernel.org >> --- >> drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- >> drivers/gpu/drm/i915/i915_utils.c | 3 +-- >> drivers/gpu/drm/i915/i915_utils.h | 2 ++ >> 3 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c >> index 2b30a45fa25c..1cf53fd4fe66 100644 >> --- a/drivers/gpu/drm/i915/i915_gpu_error.c >> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c >> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915, >> if (!xchg(&warned, true) && >> ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) { >> pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n"); >> - pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n"); >> + pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n"); >> pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n"); >> pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n"); >> pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n", >> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c >> index c47261ae86ea..9b68b21becf1 100644 >> --- a/drivers/gpu/drm/i915/i915_utils.c >> +++ b/drivers/gpu/drm/i915/i915_utils.c >> @@ -8,8 +8,7 @@ >> #include "i915_drv.h" >> #include "i915_utils.h" >> >> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI" >> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \ >> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \ >> "providing the dmesg log by booting with drm.debug=0xf" > > Space between URL and "providing"? If the following comment is accepted, then we need to change this sentence to: Please file bugs according to the instruction found at FDO_BUG_URL. > >> >> void >> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h >> index 04139ba1191e..13674b016092 100644 >> --- a/drivers/gpu/drm/i915/i915_utils.h >> +++ b/drivers/gpu/drm/i915/i915_utils.h >> @@ -34,6 +34,8 @@ >> struct drm_i915_private; >> struct timer_list; >> >> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?" > > Do we really need the question mark? We may want to point to https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-file-i915-bugs, don't you think? Martin > > BR, > Jani. > >> + >> #undef WARN_ON >> /* Many gcc seem to no see through this and fall over :( */ >> #if 0 >