From: Hans de Goede <hdegoede@redhat.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Samuel Clark <slc2015@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] i2c: designware: Fix handling of real but unexpected device interrupts
Date: Wed, 28 Sep 2022 10:13:25 +0200 [thread overview]
Message-ID: <5b8a4060-b800-6701-e0c9-cc8dfa0e6b67@redhat.com> (raw)
In-Reply-To: <31477388-b57b-5383-9c6a-18905c28253e@linux.intel.com>
Hi Jarkko,
On 9/28/22 07:49, Jarkko Nikula wrote:
> + Hans
>
> I forgot to Cc you yesterday even especially had a question for you :-(
Yes I can test this on BYT and CHT hw where one of the i2c-designware
busses is shared with the PUNIT. I have added this patch to me personal
tree which I regularly test on these kinda devices.
I will let you know if I hit any issues, if you don't hear anything from
me then you can assume I have not hit any issues :)
You also mention being especially interested on testing on hw where
the interrupt line is shared with other devices. I don't think the
i2c-designware interrupts are ever shared with other hw on the BYT/CHT
devices I have.
Regards,
Hans
> Patch here and my comment to Andy below.
>
> https://patchwork.ozlabs.org/project/linux-i2c/patch/20220927135644.1656369-1-jarkko.nikula@linux.intel.com/
>
> On 9/27/22 17:35, Andy Shevchenko wrote:
>> On Tue, Sep 27, 2022 at 04:56:44PM +0300, Jarkko Nikula wrote:
>>> #define STATUS_IDLE 0x0
>>
>> A side note: I think the clearer is to use STATUS_MASK and use
>> '&= ~STATUS_MASK' instead of '= STATUS_IDLE' in the affected pieces
>> of the code.
>>
>>> -#define STATUS_WRITE_IN_PROGRESS 0x1
>>> -#define STATUS_READ_IN_PROGRESS 0x2
>>> +#define STATUS_ACTIVE 0x1
>>> +#define STATUS_WRITE_IN_PROGRESS 0x2
>>> +#define STATUS_READ_IN_PROGRESS 0x4
>>
>> Can we at the same time replace them with BIT()?
>>
>> ...
>>
>> Otherwise looks good to me,
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
> Good points. I'll add these to follow up patches.
>
> Jarkko
>
next prev parent reply other threads:[~2022-09-28 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 13:56 [PATCH] i2c: designware: Fix handling of real but unexpected device interrupts Jarkko Nikula
2022-09-27 14:35 ` Andy Shevchenko
2022-09-28 5:49 ` Jarkko Nikula
2022-09-28 8:13 ` Hans de Goede [this message]
2022-10-01 22:40 ` Wolfram Sang
2022-10-02 8:10 ` Hans de Goede
2022-10-05 19:01 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b8a4060-b800-6701-e0c9-cc8dfa0e6b67@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=slc2015@gmail.com \
--cc=stable@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).