From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB87C433F5 for ; Thu, 10 Mar 2022 12:23:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241976AbiCJMYC (ORCPT ); Thu, 10 Mar 2022 07:24:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241971AbiCJMYB (ORCPT ); Thu, 10 Mar 2022 07:24:01 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B5E5C4A3FB for ; Thu, 10 Mar 2022 04:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646914978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hF4IPwDjQWvTDGnUGpdqamcykshZ8gvGsFBFPC99SW4=; b=I+qjr60cX4g+J5XwNKfXa4WpYmp3z0u9h5k9QHiO0IeNORovP89xFJvFQY5yVWXQAsraf+ ZZAleveVhvXiJhfsaR9sxBM+cDMp6mAnBWyKOdzK+zzV3XMu23D3Y4fCtAs6UoAtq9pJ8k 2VB+I1rAWVlxQBPrWLH6NBhnkunHIKM= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-486-U_QBwgwtMnm1jRQqvjIQKQ-1; Thu, 10 Mar 2022 07:22:57 -0500 X-MC-Unique: U_QBwgwtMnm1jRQqvjIQKQ-1 Received: by mail-ej1-f70.google.com with SMTP id 13-20020a170906328d00b006982d0888a4so2991016ejw.9 for ; Thu, 10 Mar 2022 04:22:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hF4IPwDjQWvTDGnUGpdqamcykshZ8gvGsFBFPC99SW4=; b=cuY9k7hU0rGb9kQVJ16eI7IjYtIHtCgRalQAy/fVRK3oNduhSiaDsAlaXk6N12WqxW T2z/27i0qZ5mbckM4xCHP9mpnFZNgGW5IIj7tPewH3jY0A9gkrbTPt4wam35c0EFlOfu zCRgUIIKLGRJsF8jcoUj8TF+52nkv6o2opI9UBp8XIYr3a9vSoJRguzl735tQH2fP8XU UVwiCrny5GUrnmS5Em8nJgrF4RGIDndUFSg6oI8STAjHkcOAsZ+8jUdLNBj7SKSyHEW5 QjH9KpaEa0ppGKCRFLmEscP/AdH7g6m8jSk5w6nxQpdpHnmiFvppMf+wVCwdVBk1KLEa e4GA== X-Gm-Message-State: AOAM5337kKAoZ/+NjW3Wxo409Yle7dVlUKBK9QAmy7wuL2UzSezCQmuf TfCaOGuzR+aR2E57GVL652GtFF7DuOxUumHYg1s28rXpnT3w3G4vx9rTYyPO/skesjSakV2ZPb6 Uji+PcJ097OcbFqfw X-Received: by 2002:a05:6402:1042:b0:416:5b93:eae7 with SMTP id e2-20020a056402104200b004165b93eae7mr4209466edu.84.1646914976360; Thu, 10 Mar 2022 04:22:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJz1SJYWP5VagFvpoCai07rkPdd2gkWTXVX2uM0BwwPXPrEqCxxmQCRAMR9+jCyc1DCsqfY8pQ== X-Received: by 2002:a05:6402:1042:b0:416:5b93:eae7 with SMTP id e2-20020a056402104200b004165b93eae7mr4209442edu.84.1646914976093; Thu, 10 Mar 2022 04:22:56 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:cdb2:2781:c55:5db0? (2001-1c00-0c1e-bf00-cdb2-2781-0c55-5db0.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:cdb2:2781:c55:5db0]) by smtp.gmail.com with ESMTPSA id i22-20020a170906251600b006d6d9081f46sm1730858ejb.150.2022.03.10.04.22.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Mar 2022 04:22:55 -0800 (PST) Message-ID: <5fb0cbe8-5f9d-1c75-ae0a-5909624189d3@redhat.com> Date: Thu, 10 Mar 2022 13:22:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: Many reports of laptops getting hot while suspended with kernels >= 5.16.10 || >= 5.17-rc1 Content-Language: en-US To: "Rafael J. Wysocki" Cc: Linux PM , Stable , Justin Forbes , Mark Pearson , ACPI Devel Maling List References: <31b9d1cd-6a67-218b-4ada-12f72e6f00dc@redhat.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi, On 3/10/22 11:56, Rafael J. Wysocki wrote: > On Thu, Mar 10, 2022 at 10:07 AM Hans de Goede wrote: >> >> Hi, >> >> On 3/9/22 19:27, Rafael J. Wysocki wrote: >>> On Wed, Mar 9, 2022 at 5:34 PM Rafael J. Wysocki wrote: >>>> >>>> On Wed, Mar 9, 2022 at 5:33 PM Hans de Goede wrote: >>>>> >>>>> Hi, >>>>> >>>>> On 3/9/22 14:57, Rafael J. Wysocki wrote: >>>>>> On Wed, Mar 9, 2022 at 2:44 PM Hans de Goede wrote: >>>>>>> >>>>>>> Hi Rafael, >>>>>>> >>>>>>> We (Fedora) have been receiving a whole bunch of bug reports about >>>>>>> laptops getting hot/toasty while suspended with kernels >= 5.16.10 >>>>>>> and this seems to still happen with 5.17-rc7 too. >>>>>>> >>>>>>> The following are all bugzilla.redhat.com bug numbers: >>>>>>> >>>>>>> 1750910 - Laptop failed to suspend and completely drained the battery >>>>>>> 2050036 - Framework laptop: 5.16.5 breaks s2idle sleep >>>>>>> 2053957 - Package c-states never go below C2 >>>>>>> 2056729 - No lid events when closing lid / laptop does not suspend >>>>>>> 2057909 - Thinkpad X1C 9th in s2idle suspend still draining battery to zero over night , Ap >>>>>>> 2059668 - HP Envy Laptop deadlocks on entering suspend power state when plugged in. Case ge >>>>>>> 2059688 - Dell G15 5510 s2idle fails in 5.16.11 works in 5.16.10 >>>>>>> >>>>>>> And one of the bugs has also been mirrored at bugzilla.kernel.org by >>>>>>> the reporter: >>>>>>> >>>>>>> bko215641 - Dell G15 5510 s2idle fails in 5.16.11 works in 5.16.10 >>>>>>> >>>>>>> The common denominator here (besides the kernel version) seems to >>>>>>> be that these are all Ice or Tiger Lake systems (I did not do >>>>>>> check this applies 100% to all bugs, but it does see, to be a pattern). >>>>>>> >>>>>>> A similar arch-linux report: >>>>>>> >>>>>>> https://bbs.archlinux.org/viewtopic.php?id=274292&p=2 >>>>>>> >>>>>>> Suggest that reverting >>>>>>> "ACPI: PM: s2idle: Cancel wakeup before dispatching EC GPE" >>>>>>> >>>>>>> which was cherry-picked into 5.16.10 fixes things. >>>>>> >>>>>> Thanks for letting me know! >>>>>> >>>>>>> If you want I can create Fedora kernel test-rpms of a recent >>>>>>> 5.16.y with just that one commit reverted and ask users to >>>>>>> confirm if that helps. Please let me know if doing that woulkd >>>>>>> be useful ? >>>>>> >>>>>> Yes, it would. >>>>>> >>>>>> However, it follows from the arch-linux report linked above that >>>>>> 5.17-rc is fine, so it would be good to also check if reverting that >>>>>> commit from 5.17-rc helps. >>>>> >>>>> Ok, I've done Fedora kernel builds of both 5.16.13 and 5.17-rc7 with >>>>> the patch reverted and asked the bug-reporters to test both. >>>> >>>> Thanks! >>> >>> Also, in the cases where people have not tested 5.17-rc7 without any >>> reverts, it would be good to ask them to do so. >> >> Ok, done. >> >>> I have received another report related to this issue where the problem >>> is not present in 5.17-rc7 (see >>> https://lore.kernel.org/linux-pm/CAJZ5v0hKXyTtb1Jk=wqNV9_mZKdf3mmwF4bPOcmADyNnTkpMbQ@mail.gmail.com/). >> >> The first results from the Fedora test kernel builds are in: >> >> "HP Envy Laptop deadlocks on entering suspend power state when plugged in. Case gets very hot and requires a power button hold to restart" >> https://bugzilla.redhat.com/show_bug.cgi?id=2059668 >> >> 5.16.9: good >> 5.16.10+: bad >> 5.16.13 with "ACPI: PM: s2idle: Cancel wakeup before dispatching EC GPE" reverted: good >> 5.17-rc7 with "ACPI: PM: s2idle: Cancel wakeup before dispatching EC GPE" reverted: good >> 5.17-rc7 (plain): good >> >> So this seems to match the arch-linux report and the email report >> you linked. There is a problem with the backport in 5.16.10+, >> while 5.17-rc7 is fine. >> >>> It is likely that the commit in question actually depends on some >>> other commits that were not backported into 5.16.y. >> I was thinking the same thing, but I've no idea which commits >> that would be. > > I do have an idea, but regardless of this, IMO the least risky way > forward would be to request "stable" to drop "ACPI: PM: s2idle: Cancel > wakeup before dispatching EC GPE" which has been backported, because > it carried a Fixes tag and not because it was marked for "stable". > > Let me do that. Ok, that sounds good, thank you. Regards, Hans